-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Skip Code CI for non code changes #22894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
comphead
wants to merge
3
commits into
apache:main
Choose a base branch
from
comphead:chore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+192
−17
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # Single source of truth for which PR diffs should skip code CI. | ||
| # | ||
| # Workflows that gate jobs on "is this a real code change?" call this | ||
| # composite action; every existing job downstream then uses | ||
| # `if: needs.detect-changes.outputs.has_code == 'true'`. The caller is | ||
| # responsible for `actions/checkout` with `fetch-depth: 0` before invoking | ||
| # this action; we need full history to compute the PR diff. | ||
|
|
||
| name: 'Detect changes' | ||
| description: >- | ||
| Emit has_code='true' if the PR contains any changed file that does NOT | ||
| match `ignore-paths`. When every changed file matches, has_code='false' | ||
| and dependent jobs should report `skipped`. | ||
|
|
||
| inputs: | ||
| ignore-paths: | ||
| description: | | ||
| Newline-separated glob patterns. If EVERY changed file in the PR | ||
| matches one of these globs, has_code='false' (code CI is skipped, | ||
| only dev.yml / docs*.yaml jobs run). | ||
|
|
||
| Glob syntax matches `pull_request: paths-ignore:`: | ||
| ** any depth | ||
| * any chars within one path segment | ||
| foo/bar.txt a single specific file | ||
| subdir/** everything under subdir/ | ||
| **.png any .png file at any depth | ||
| **/CHANGELOG.md CHANGELOG.md in any directory | ||
|
|
||
| To add a new entry: append one line below. To override per-workflow, | ||
| pass `with: ignore-paths: |` from the caller. | ||
| required: false | ||
| default: | | ||
| docs/** | ||
| **.md | ||
| .github/ISSUE_TEMPLATE/** | ||
| .github/pull_request_template.md | ||
|
|
||
| outputs: | ||
| has_code: | ||
| description: >- | ||
| 'true' if at least one changed file is outside `ignore-paths`, | ||
| 'false' if every changed file matches one of those globs. | ||
| value: ${{ steps.filter.outputs.has_code }} | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - id: filter | ||
| shell: bash | ||
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| HEAD_SHA: ${{ github.event.pull_request.head.sha }} | ||
| IGNORE_CODE_CI_FOR_PATHS: ${{ inputs.ignore-paths }} | ||
| run: | | ||
| # Fail-open: if anything goes wrong, default to running every job | ||
| # rather than silently skipping (which would let broken CI merge). | ||
| set +e | ||
| if [ -z "$BASE_SHA" ]; then | ||
| echo "has_code=true" >> "$GITHUB_OUTPUT"; exit 0 | ||
| fi | ||
| # Translate IGNORE_CODE_CI_FOR_PATHS (one glob per line) into git | ||
| # pathspec excludes; `:(exclude,glob)` activates ** globbing. | ||
| excludes=() | ||
| while IFS= read -r pattern; do | ||
| [ -n "$pattern" ] && excludes+=( ":(exclude,glob)$pattern" ) | ||
| done <<< "$IGNORE_CODE_CI_FOR_PATHS" | ||
| # If anything remains after stripping ignored paths, the PR has | ||
| # real code changes and code CI should run. | ||
| diff_output=$(git diff --name-only "$BASE_SHA..$HEAD_SHA" -- "${excludes[@]}") | ||
| if [ -n "$diff_output" ]; then | ||
| echo "has_code=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "has_code=false" >> "$GITHUB_OUTPUT" | ||
| fi | ||
| exit 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we keep this check even for doc files?