Fix Copy equality/hashCode contract#142
Open
DragonFSKY wants to merge 1 commit into
Open
Conversation
DragonFSKY
force-pushed
the
fix-copy-equals-hashcode-contract
branch
from
cd552b1 to
1952817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.
Summary
Copies.Copy.equals(Object)use the same wallet-based identity ashashCode()compareTo(...)unchangedwith(...)preserving copy identity/hash code and for different wallets with the same score not being equalVerification
git diff --checkI also attempted
mvn -Dtest=CopiesTest test, but local execution is currently blocked before tests by the current compiler/annotation-processing setup: generated envelope classes such asScoreEnvelopeandTransactionEnvelopeare not produced locally. The latest upstreammvnworkflow onmasteris green, so I am leaving CI as the authoritative full build check for this PR.