Massive migration from context receivers to context parameters#190
Open
LionZXY wants to merge 1 commit into
Open
Massive migration from context receivers to context parameters#190LionZXY wants to merge 1 commit into
LionZXY wants to merge 1 commit into
Conversation
LionZXY
changed the title
Closed
Collaborator
|
Hi @LionZXY, I apologize for the long silence. When you opened the PR I was already working on this too and both this PR and my changes now have bunch of conflicts with the main branch. I'll probably rebase your branch, resolve the conflicts and then make some changes to some of the context usages before merging it. In any case, thank you for your contributions! (-.- clicked the wrong button, didn't mean to close this, just comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin 2.3.20 removed context receivers (CONTEXT_RECEIVERS_DEPRECATED is now a hard error and can no longer be downgraded), so compiling SKIE's own sources with the 2.3.20 compiler requires migrating off them. This bumps the build Kotlin version in libs.versions.toml from 2.2.20 to 2.3.20.
Migrates 163 files (kotlin-compiler core/linker-plugin and acceptance-tests) from context(T) receivers to named context(context: T) parameters, qualifying the previously-implicit context-member accesses (e.g. context.sirProvider) and replacing this@Context labels. The build plugin switches from enableLanguageFeature("ContextReceivers") + -Xwarning-level=CONTEXT_RECEIVERS_DEPRECATED:disabled to -Xcontext-parameters.
All linker-plugin variants (2.0.0 through 2.3.20) are compiled by the KGP-bundled 2.3.20 compiler and still build, so SKIE's multi-version target support is unchanged.