audio: eq_iir: tune: accept multiple measurement files in sof_ucm2_eq…#10987
Open
singalsu wants to merge 1 commit into
Open
audio: eq_iir: tune: accept multiple measurement files in sof_ucm2_eq…#10987singalsu wants to merge 1 commit into
singalsu wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SOF UCM2 EQ tuning generator to support averaging multiple measurement captures into a single response curve before running the existing IIR+FIR fit, enabling spatial averaging across microphone positions.
Changes:
- Allow
meas_fileto be provided as a cell array of file paths in addition to a single path string. - Load each measurement independently, average multi-column traces per file, then average across files.
- Enforce identical frequency grids across all provided measurement files and error out early on mismatch.
singalsu
force-pushed
the
eqiir_tune_ucm2_eq_add_multiple_meas
branch
from
520b6bd to
1e0e0c4
Compare
…_generate Allow the meas_file argument to be a cell array of paths in addition to a single string. Each file is still loaded and column-averaged the same way it was before; the per-file traces are then averaged together into the single response the IIR + FIR fit consumes. All files must share the exact same frequency grid. A mismatch aborts before any fit is attempted with an error that names both the offending file and the reference (first) file, so it is obvious which measurement was captured on a different grid. The main use case is a series of measurements taken with the microphone at different positions in front of the speaker, so the tuning target is the spatial average of those positions instead of the exact frequency response at one arbitrary spot. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
eqiir_tune_ucm2_eq_add_multiple_meas
branch
from
1e0e0c4 to
4f31ce1
Compare
lgirdwood
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…_generate
Allow the meas_file argument to be a cell array of paths in addition to a single string. Each file is still loaded and column-averaged the same way it was before; the per-file traces are then averaged together into the single response the IIR + FIR fit consumes.
All files must share the exact same frequency grid. A mismatch aborts before any fit is attempted with an error that names both the offending file and the reference (first) file, so it is obvious which measurement was captured on a different grid.
The main use case is a series of measurements taken with the microphone at different positions in front of the speaker, so the tuning target is the spatial average of those positions instead of the exact frequency response at one arbitrary spot.