Use $XDG_CONFIG_HOME to load config#119
Conversation
|
I am just a helper so it requires @svenfuchs to approve this change |
|
Hi @PikachuEXE, I think I fixed the issue. I also added info in README.md. Can you please run CI again? |
|
coverage: 94.025% (+0.04%) from 93.988% — kamilachludzinska-dev:master into svenfuchs:master |
|
coverage: 94.025% (+0.04%) from 93.988% — kamilachludzinska-dev:master into svenfuchs:master |
PikachuEXE
left a comment
PikachuEXE
left a comment
There was a problem hiding this comment.
Also spec fail in some ruby versions?
| * `~/.gem_release/config.yml` | ||
| * `~/.gem_release.yml` | ||
| * `$XDG_CONFIG_HOME/.gem_release/config.yml` | ||
| * `$XDG_CONFIG_HOME/.gem_release.yml` | ||
| * `./.gem_release/config.yml` | ||
| * `./.gem_release.yml` |
There was a problem hiding this comment.
I think it might be a good time to specify the order (local > XDG > global
Not sure how to word it exactly but since we have 3 places now better to spell it out
There was a problem hiding this comment.
@PikachuEXE, I changed the hardcoded list of config file locations to code execution. Let me know what you think.
Could you also run tests again, please? I find it hard to reproduce locally. Ruby 2.3 is ancient by now. ;)
|
Yup I don't know which part of the code is wrong |
|
Some tests failed, fix them when you are available~ |
|
I should have time this weekend to look into this, but so far I don't have local repro. :( I'll let you know when I have something. |
3 participants
Config::Fileswas only using hardcoded paths from a constantPATHS.XDG Base Directory standard suggests that user-specific configuration should be written to $XDG_CONFIG_HOME.
Use
$XDG_CONFIG_HOME, so that user can store files where they prefer (under version control etc.).