feat(output): add basic opentelemetry output#971
Draft
Molter73 wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 33.85% 33.99% +0.14%
==========================================
Files 21 21
Lines 2812 2871 +59
Branches 2812 2871 +59
==========================================
+ Hits 952 976 +24
- Misses 1857 1892 +35
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This output allows exporting file activity events as opentelemetry logs via otlp to be collected by compatible systems. TODO: * Add feature flag * Add configuration * Add integration tests * Add docs on how to use this output
Molter73
force-pushed
the
mauro/feat/otel-output
branch
from
486adb1 to
c2d0d32
Compare
The new way for output components to resubscribe the broadcast channel distributing events is to send a oneshot sender back to the main task which will resubscribe from the broadcast sender and forward the receiver back. While this approach might seem overly complicated, it ensures there will be no lingering receivers laying around, which in turn allows for Arc::unwrap_or_clone to properly unwrap all messages when only one output is in use.
This allows regular fact builds to keep using just the gRPC and stodout outputs, no additional dependencies.
Molter73
force-pushed
the
mauro/feat/otel-output
branch
from
adbbbd2 to
3803d50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This output allows exporting file activity events as opentelemetry logs via otlp to be collected by compatible systems.
TODO:
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TBD