Skip to content

Mitigate ClangFormat max argument size#2592

Merged
jviotti merged 2 commits into
mainfrom
clang-format-fix
Jul 3, 2026
Merged

Mitigate ClangFormat max argument size#2592
jviotti merged 2 commits into
mainfrom
clang-format-fix

Conversation

@jviotti

@jviotti jviotti commented Jul 3, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread cmake/common/targets/clang-format.cmake
@augmentcode

augmentcode Bot commented Jul 3, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the CMake-based ClangFormat targets to mitigate operating-system command-line length limits by batching formatting invocations.

Changes:

  • Builds batched command lists for clang_format and clang_format_test.
  • Replaces the single large clang-format call with multiple calls over smaller file batches.
  • Keeps the same style configuration path logic while introducing a fixed batch size knob.

Technical Notes: Intended primarily to reduce failures on Windows (CreateProcess argument size limits) as the source set grows.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread cmake/common/targets/clang-format.cmake Outdated
Comment thread cmake/common/targets/clang-format.cmake
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 7d64593 Previous: 531d7ac Ratio
JOSE_VerifySignature_RS256 22747.951995582152 ns/iter 22156.86905385615 ns/iter 1.03
JOSE_VerifySignature_ES512 576891.4100660215 ns/iter 575315.4740741143 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Locations 36609229.31579223 ns/iter 36594068.10526746 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Locations 4379197.556249892 ns/iter 4310501.820359768 ns/iter 1.02
GZIP_Compress_ISO_Language_Set_3_Schema 2036600.3014494022 ns/iter 2024711.3101451788 ns/iter 1.01
GZIP_Decompress_ISO_Language_Set_3_Schema 379364.3577235585 ns/iter 379419.1193705904 ns/iter 1.00
HTML_Build_Table_100000 59964440.583333574 ns/iter 60054896.916663356 ns/iter 1.00
HTML_Render_Table_100000 1894145.022408914 ns/iter 1946059.9408452716 ns/iter 0.97
JSONL_Parse_Large 13086889.111110412 ns/iter 12687394.963636093 ns/iter 1.03
JSONL_Parse_Large_GZIP 14408652.428570276 ns/iter 14062129.199999163 ns/iter 1.02
URITemplateRouter_Create 30411.395836937863 ns/iter 29965.46954982952 ns/iter 1.01
URITemplateRouter_Match 153.86966045206276 ns/iter 154.01071556602255 ns/iter 1.00
URITemplateRouter_Match_BasePath 179.1735846266634 ns/iter 179.53151654264292 ns/iter 1.00
URITemplateRouterView_Restore 8480.049883048594 ns/iter 8470.024169653116 ns/iter 1.00
URITemplateRouterView_Match 124.20295022810606 ns/iter 124.0539229961475 ns/iter 1.00
URITemplateRouterView_Match_BasePath 142.63491133022282 ns/iter 142.24675641865218 ns/iter 1.00
URITemplateRouterView_Arguments 473.1049838040586 ns/iter 476.69497399647156 ns/iter 0.99
Pointer_Object_Traverse 30.003216689409633 ns/iter 30.249365923505245 ns/iter 0.99
Pointer_Object_Try_Traverse 20.212009229685112 ns/iter 20.22877716354188 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 150.14900739203438 ns/iter 133.83166214146024 ns/iter 1.12
Pointer_Walker_Schema_ISO_Language 1879801.1455024371 ns/iter 1865217.5317460585 ns/iter 1.01
Pointer_Maybe_Tracked_Deeply_Nested/0 1537252.6031388598 ns/iter 1529230.6965064271 ns/iter 1.01
Pointer_Maybe_Tracked_Deeply_Nested/1 1680170.2331730002 ns/iter 1854992.5582012518 ns/iter 0.91
Pointer_Position_Tracker_Get_Deeply_Nested 593.525129769592 ns/iter 582.2300674747761 ns/iter 1.02
JSON_Array_Of_Objects_Unique 393.3610010576113 ns/iter 403.0945566247202 ns/iter 0.98
JSON_Parse_1 7660.445064058193 ns/iter 7516.406888850269 ns/iter 1.02
JSON_Parse_Real 6853.739313988747 ns/iter 6712.987044178262 ns/iter 1.02
JSON_Parse_Decimal 11247.584438522996 ns/iter 11163.546990680508 ns/iter 1.01
JSON_Parse_Schema_ISO_Language 5098338.791367169 ns/iter 5098734.20438008 ns/iter 1.00
JSON_Parse_Integer 4850.002078310862 ns/iter 4855.453210510497 ns/iter 1.00
JSON_Parse_String_NonSSO_Plain 8545.623646286158 ns/iter 8647.398282360758 ns/iter 0.99
JSON_Parse_String_SSO_Plain 3910.3412278006235 ns/iter 3930.3218707166775 ns/iter 0.99
JSON_Parse_String_Escape_Heavy 21080.718505359204 ns/iter 21053.08167639147 ns/iter 1.00
JSON_Parse_Object_Short_Keys 11378.735928339476 ns/iter 11109.99221870819 ns/iter 1.02
JSON_Parse_Object_Scalar_Properties 5854.499372983091 ns/iter 5725.408870171326 ns/iter 1.02
JSON_Parse_Object_Array_Properties 8779.386124473462 ns/iter 9015.345116003711 ns/iter 0.97
JSON_Parse_Object_Object_Properties 9457.397566224545 ns/iter 9202.083952598774 ns/iter 1.03
JSON_Parse_Nested_Containers 71709.1440599716 ns/iter 71436.78504387218 ns/iter 1.00
JSON_From_String_Copy 18.312679652188752 ns/iter 18.243945281083782 ns/iter 1.00
JSON_From_String_Temporary 15.37478568065912 ns/iter 15.353137811674308 ns/iter 1.00
JSON_Number_To_Double 22.14093505947317 ns/iter 22.12516801433623 ns/iter 1.00
JSON_Object_At_Last_Key/8 5.945125854920707 ns/iter 5.926157415124799 ns/iter 1.00
JSON_Object_At_Last_Key/32 21.52447823749731 ns/iter 21.526875220684886 ns/iter 1.00
JSON_Object_At_Last_Key/128 87.2728491918185 ns/iter 87.91622789100965 ns/iter 0.99
JSON_Object_At_Last_Key/512 424.7665122932316 ns/iter 426.73292288814343 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 67.28335690870071 ns/iter 55.45996585652892 ns/iter 1.21
JSON_Equality_Helm_Chart_Lock 155.66054717530585 ns/iter 156.24541985627215 ns/iter 1.00
JSON_Divisible_By_Decimal 238.85678709061452 ns/iter 236.56747724857846 ns/iter 1.01
JSON_String_Equal/10 6.349238452705636 ns/iter 6.351399409682264 ns/iter 1.00
JSON_String_Equal/100 7.244573597213076 ns/iter 6.97845803769159 ns/iter 1.04
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7492115419028547 ns/iter 0.748815577571314 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 25.203257460243385 ns/iter 25.19013984397244 ns/iter 1.00
JSON_String_Fast_Hash/10 0.9365643264299719 ns/iter 0.9336641831355454 ns/iter 1.00
JSON_String_Fast_Hash/100 0.9478818095449391 ns/iter 0.9339494394109418 ns/iter 1.01
JSON_String_Key_Hash/10 1.5605377267389167 ns/iter 1.5577590209463796 ns/iter 1.00
JSON_String_Key_Hash/100 12.451120264149543 ns/iter 12.440466877692089 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 3.4284147224029913 ns/iter 3.4261011240695196 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.4418275413493036 ns/iter 3.4308579443529954 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.120288579116888 ns/iter 3.115205801494683 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 0.6232244085592065 ns/iter 0.623582603305228 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.6238860630924014 ns/iter 0.6409424800583898 ns/iter 0.97
Regex_Period_Asterisk 0.93456310507929 ns/iter 0.93454449091092 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 0.9347904228438004 ns/iter 0.9349245945594474 ns/iter 1.00
Regex_Period_Plus 0.6233865026536343 ns/iter 0.6230743330695406 ns/iter 1.00
Regex_Period 0.6269377982185201 ns/iter 0.6230834330761691 ns/iter 1.01
Regex_Caret_Period_Plus_Dollar 0.9350607032957923 ns/iter 0.9354696693835768 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 0.9345605980185012 ns/iter 0.9420256002735561 ns/iter 0.99
Regex_Caret_Period_Asterisk_Dollar 0.6230872740507795 ns/iter 0.6234244616664687 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.6232550230656111 ns/iter 0.6233695313589973 ns/iter 1.00
Regex_Caret_X_Hyphen 4.060359522860627 ns/iter 4.05305968798689 ns/iter 1.00
Regex_Period_Md_Dollar 29.664428333974875 ns/iter 39.21630064173723 ns/iter 0.76
Regex_Caret_Slash_Period_Asterisk 4.687316553509366 ns/iter 4.670111891741154 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 0.779188953527308 ns/iter 0.778945603420893 ns/iter 1.00
Regex_Nested_Backtrack 36.43580679267702 ns/iter 37.037071643726634 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 7d64593 Previous: 531d7ac Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.6996525571863967 ns/iter 2.3920518555009913 ns/iter 0.71
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.684980226459749 ns/iter 1.8108791947470098 ns/iter 0.93
Regex_Period_Asterisk 1.6403085470522907 ns/iter 2.1994816099244927 ns/iter 0.75
Regex_Group_Period_Asterisk_Group 1.7002720570686805 ns/iter 2.050035326054512 ns/iter 0.83
Regex_Period_Plus 2.0167518741862756 ns/iter 2.3828571444044075 ns/iter 0.85
Regex_Period 2.0810653564366737 ns/iter 2.5413658730155335 ns/iter 0.82
Regex_Caret_Period_Plus_Dollar 2.0404142733624053 ns/iter 2.163144673359324 ns/iter 0.94
Regex_Caret_Group_Period_Plus_Group_Dollar 1.9701878676668934 ns/iter 2.2407887587597672 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 1.6746617387104181 ns/iter 1.8393348998947672 ns/iter 0.91
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.715083592633608 ns/iter 2.072801945872586 ns/iter 0.83
Regex_Caret_X_Hyphen 6.304825167192097 ns/iter 6.542500863599438 ns/iter 0.96
Regex_Period_Md_Dollar 17.40903761244003 ns/iter 22.71204328543213 ns/iter 0.77
Regex_Caret_Slash_Period_Asterisk 4.475495714157447 ns/iter 5.9599674447798066 ns/iter 0.75
Regex_Caret_Period_Range_Dollar 2.002902900996793 ns/iter 2.235263669492458 ns/iter 0.90
Regex_Nested_Backtrack 24.326831737159875 ns/iter 28.64033903100545 ns/iter 0.85
JSON_Array_Of_Objects_Unique 397.86930604342746 ns/iter 547.4400439515646 ns/iter 0.73
JSON_Parse_1 5445.002086437429 ns/iter 8002.045767764905 ns/iter 0.68
JSON_Parse_Real 6133.553045441029 ns/iter 8728.015048580388 ns/iter 0.70
JSON_Parse_Decimal 6593.387265619672 ns/iter 7684.414850366555 ns/iter 0.86
JSON_Parse_Schema_ISO_Language 2953089.392071828 ns/iter 4300546.0199001795 ns/iter 0.69
JSON_Parse_Integer 3899.455603529209 ns/iter 4693.6850774418535 ns/iter 0.83
JSON_Parse_String_NonSSO_Plain 5502.0490921500395 ns/iter 6719.37246323808 ns/iter 0.82
JSON_Parse_String_SSO_Plain 2274.4174402764947 ns/iter 2628.4818475464353 ns/iter 0.87
JSON_Parse_String_Escape_Heavy 19437.19927555825 ns/iter 22970.39598496152 ns/iter 0.85
JSON_Parse_Object_Short_Keys 6691.988418609205 ns/iter 7820.53846393981 ns/iter 0.86
JSON_Parse_Object_Scalar_Properties 3425.543301609324 ns/iter 3797.9832050181285 ns/iter 0.90
JSON_Parse_Object_Array_Properties 5436.62884549746 ns/iter 5473.817592172674 ns/iter 0.99
JSON_Parse_Object_Object_Properties 5595.144846639461 ns/iter 6995.167286304909 ns/iter 0.80
JSON_Parse_Nested_Containers 46527.755518599406 ns/iter 57972.778745642005 ns/iter 0.80
JSON_From_String_Copy 27.04378502102644 ns/iter 26.425212950806184 ns/iter 1.02
JSON_From_String_Temporary 20.65667282142413 ns/iter 21.242331606024862 ns/iter 0.97
JSON_Number_To_Double 31.083247634985828 ns/iter 36.98322111925416 ns/iter 0.84
JSON_Object_At_Last_Key/8 3.8740856041111065 ns/iter 3.726531977051018 ns/iter 1.04
JSON_Object_At_Last_Key/32 11.998356925886622 ns/iter 12.080057320660206 ns/iter 0.99
JSON_Object_At_Last_Key/128 57.18961717039997 ns/iter 60.98339805066777 ns/iter 0.94
JSON_Object_At_Last_Key/512 182.78351002205244 ns/iter 193.9193233307755 ns/iter 0.94
JSON_Fast_Hash_Helm_Chart_Lock 58.70954497621259 ns/iter 59.34895924687373 ns/iter 0.99
JSON_Equality_Helm_Chart_Lock 131.8094933345046 ns/iter 135.2223788203673 ns/iter 0.97
JSON_Divisible_By_Decimal 174.34841299712957 ns/iter 178.8745190591441 ns/iter 0.97
JSON_String_Equal/10 6.7873488532507595 ns/iter 6.858035274299982 ns/iter 0.99
JSON_String_Equal/100 6.376849691130065 ns/iter 6.703095794764843 ns/iter 0.95
JSON_String_Equal_Small_By_Perfect_Hash/10 0.3491374197735558 ns/iter 0.3437649766834316 ns/iter 1.02
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.2350213735731885 ns/iter 3.5946660066333647 ns/iter 0.90
JSON_String_Fast_Hash/10 2.2963533815995216 ns/iter 2.6004107850238376 ns/iter 0.88
JSON_String_Fast_Hash/100 2.1552417500190466 ns/iter 2.1591464721265656 ns/iter 1.00
JSON_String_Key_Hash/10 1.7063226913962901 ns/iter 1.714356111054298 ns/iter 1.00
JSON_String_Key_Hash/100 2.0434592261152598 ns/iter 2.0980936677680893 ns/iter 0.97
JSON_Object_Defines_Miss_Same_Length 2.7175420317279215 ns/iter 2.9723784644849993 ns/iter 0.91
JSON_Object_Defines_Miss_Too_Small 2.688942942127118 ns/iter 2.796436474198436 ns/iter 0.96
JSON_Object_Defines_Miss_Too_Large 2.6504947245349553 ns/iter 2.754936785012443 ns/iter 0.96
Pointer_Object_Traverse 18.58689164249483 ns/iter 20.24506869934022 ns/iter 0.92
Pointer_Object_Try_Traverse 17.336858653186603 ns/iter 18.372995940750986 ns/iter 0.94
Pointer_Push_Back_Pointer_To_Weak_Pointer 160.0570385175977 ns/iter 185.7252278053055 ns/iter 0.86
Pointer_Walker_Schema_ISO_Language 1597331.3078705831 ns/iter 1641835.9594595828 ns/iter 0.97
Pointer_Maybe_Tracked_Deeply_Nested/0 999856.7518253692 ns/iter 1048806.6044443392 ns/iter 0.95
Pointer_Maybe_Tracked_Deeply_Nested/1 959374.3844086158 ns/iter 1003598.8670520345 ns/iter 0.96
Pointer_Position_Tracker_Get_Deeply_Nested 335.4800644322372 ns/iter 340.9560909746097 ns/iter 0.98
URITemplateRouter_Create 22429.677217723056 ns/iter 23574.25584603617 ns/iter 0.95
URITemplateRouter_Match 166.58292724957724 ns/iter 175.50131138713823 ns/iter 0.95
URITemplateRouter_Match_BasePath 198.02299808363935 ns/iter 198.19941266929962 ns/iter 1.00
URITemplateRouterView_Restore 9976.626684848809 ns/iter 10868.278247028917 ns/iter 0.92
URITemplateRouterView_Match 141.93090575801276 ns/iter 138.9946703842812 ns/iter 1.02
URITemplateRouterView_Match_BasePath 164.04825996693847 ns/iter 163.07204355317347 ns/iter 1.01
URITemplateRouterView_Arguments 551.3973750217423 ns/iter 558.6784080727092 ns/iter 0.99
JSONL_Parse_Large 9924234.375003178 ns/iter 11467576.508197617 ns/iter 0.87
JSONL_Parse_Large_GZIP 12920018.145164689 ns/iter 13091178.967211727 ns/iter 0.99
HTML_Build_Table_100000 35873981.49999091 ns/iter 40484223.684212625 ns/iter 0.89
HTML_Render_Table_100000 1570067.61477017 ns/iter 1845508.395522426 ns/iter 0.85
GZIP_Compress_ISO_Language_Set_3_Locations 26389028.846167024 ns/iter 26853280.461540844 ns/iter 0.98
GZIP_Decompress_ISO_Language_Set_3_Locations 3063447.247706056 ns/iter 3506292.2679424915 ns/iter 0.87
GZIP_Compress_ISO_Language_Set_3_Schema 1518287.0952371813 ns/iter 1627308.2232142347 ns/iter 0.93
GZIP_Decompress_ISO_Language_Set_3_Schema 273618.52479505196 ns/iter 280645.26255708 ns/iter 0.97
JOSE_VerifySignature_RS256 20862.165280912537 ns/iter 21445.86453060184 ns/iter 0.97
JOSE_VerifySignature_ES512 1119047.907956859 ns/iter 1081143.217054203 ns/iter 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 7d64593 Previous: 531d7ac Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.814297822426809 ns/iter 2.489341451548998 ns/iter 1.13
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4622876752285827 ns/iter 2.1778584099959484 ns/iter 1.13
Regex_Period_Asterisk 2.4622169946548214 ns/iter 2.178559464930017 ns/iter 1.13
Regex_Group_Period_Asterisk_Group 2.812051984587568 ns/iter 2.4897004150260957 ns/iter 1.13
Regex_Period_Plus 4.218677180555749 ns/iter 3.13117494263245 ns/iter 1.35
Regex_Period 3.866930539998953 ns/iter 2.801109380617041 ns/iter 1.38
Regex_Caret_Period_Plus_Dollar 2.4604498079100385 ns/iter 2.802346687648986 ns/iter 0.88
Regex_Caret_Group_Period_Plus_Group_Dollar 2.8146924933020347 ns/iter 3.113036168132438 ns/iter 0.90
Regex_Caret_Period_Asterisk_Dollar 4.3016851334386805 ns/iter 3.7378798907569473 ns/iter 1.15
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.9426379817 ns/iter 3.4245452945892776 ns/iter 1.15
Regex_Caret_X_Hyphen 7.031818564993246 ns/iter 6.645461385566615 ns/iter 1.06
Regex_Period_Md_Dollar 26.625295322043137 ns/iter 28.755911648586586 ns/iter 0.93
Regex_Caret_Slash_Period_Asterisk 7.740998846554113 ns/iter 6.222739066887458 ns/iter 1.24
Regex_Caret_Period_Range_Dollar 3.8661311959006097 ns/iter 3.735951125639523 ns/iter 1.03
Regex_Nested_Backtrack 37.93972581165931 ns/iter 37.53929235270093 ns/iter 1.01
JSON_Array_Of_Objects_Unique 476.052342159975 ns/iter 441.3504069265087 ns/iter 1.08
JSON_Parse_1 4779.686723888668 ns/iter 4869.041373436439 ns/iter 0.98
JSON_Parse_Real 5103.68466577626 ns/iter 5355.177168775677 ns/iter 0.95
JSON_Parse_Decimal 7642.919060821652 ns/iter 7694.433092043976 ns/iter 0.99
JSON_Parse_Schema_ISO_Language 3727924.5368423336 ns/iter 3553651.121827214 ns/iter 1.05
JSON_Parse_Integer 3944.3986874900634 ns/iter 3770.575324521058 ns/iter 1.05
JSON_Parse_String_NonSSO_Plain 5171.913909028361 ns/iter 5086.686457386126 ns/iter 1.02
JSON_Parse_String_SSO_Plain 2969.7877508232796 ns/iter 2862.5654199864166 ns/iter 1.04
JSON_Parse_String_Escape_Heavy 14446.4197144215 ns/iter 14110.532417571407 ns/iter 1.02
JSON_Parse_Object_Short_Keys 8036.795972430127 ns/iter 7771.298140092011 ns/iter 1.03
JSON_Parse_Object_Scalar_Properties 4171.539437412917 ns/iter 4037.2407554380047 ns/iter 1.03
JSON_Parse_Object_Array_Properties 5684.448296866728 ns/iter 5807.721971866168 ns/iter 0.98
JSON_Parse_Object_Object_Properties 5633.206357007691 ns/iter 5859.184012319122 ns/iter 0.96
JSON_Parse_Nested_Containers 46297.69804441378 ns/iter 45064.79193850189 ns/iter 1.03
JSON_From_String_Copy 22.20250305940489 ns/iter 20.2463168190375 ns/iter 1.10
JSON_From_String_Temporary 20.079624593183475 ns/iter 18.081091982306187 ns/iter 1.11
JSON_Number_To_Double 22.929052802127135 ns/iter 23.36938960904369 ns/iter 0.98
JSON_Object_At_Last_Key/8 3.56906047665305 ns/iter 3.7304169746854594 ns/iter 0.96
JSON_Object_At_Last_Key/32 13.014361883968032 ns/iter 11.92348111204649 ns/iter 1.09
JSON_Object_At_Last_Key/128 47.61063836853607 ns/iter 50.28439657617354 ns/iter 0.95
JSON_Object_At_Last_Key/512 366.1057486304708 ns/iter 383.6861059573216 ns/iter 0.95
JSON_Fast_Hash_Helm_Chart_Lock 79.17747259662895 ns/iter 65.99183874229304 ns/iter 1.20
JSON_Equality_Helm_Chart_Lock 163.0909314707348 ns/iter 183.08188364958025 ns/iter 0.89
JSON_Divisible_By_Decimal 245.3105462924176 ns/iter 247.12924352755132 ns/iter 0.99
JSON_String_Equal/10 5.977770384108163 ns/iter 6.235545534045868 ns/iter 0.96
JSON_String_Equal/100 6.6846519005775065 ns/iter 6.858435905069576 ns/iter 0.97
JSON_String_Equal_Small_By_Perfect_Hash/10 1.0549578554142534 ns/iter 0.936269016833075 ns/iter 1.13
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 12.337591405777795 ns/iter 14.929392493602837 ns/iter 0.83
JSON_String_Fast_Hash/10 2.817714630063714 ns/iter 2.8018085334840745 ns/iter 1.01
JSON_String_Fast_Hash/100 2.814464538384151 ns/iter 2.802464263719707 ns/iter 1.00
JSON_String_Key_Hash/10 2.463589797168179 ns/iter 2.7540546151970315 ns/iter 0.89
JSON_String_Key_Hash/100 8.08998672476849 ns/iter 9.083342118160092 ns/iter 0.89
JSON_Object_Defines_Miss_Same_Length 2.95913772072629 ns/iter 2.5565454512182777 ns/iter 1.16
JSON_Object_Defines_Miss_Too_Small 4.2238438626992325 ns/iter 3.736179658179758 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Large 3.0474584576268002 ns/iter 2.723966029217635 ns/iter 1.12
Pointer_Object_Traverse 26.53457595581935 ns/iter 24.027617524867523 ns/iter 1.10
Pointer_Object_Try_Traverse 30.65413711562566 ns/iter 30.200627148859276 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 223.4970514618633 ns/iter 217.38460042509195 ns/iter 1.03
Pointer_Walker_Schema_ISO_Language 1837550.5937499406 ns/iter 1756460.9007443844 ns/iter 1.05
Pointer_Maybe_Tracked_Deeply_Nested/0 1336516.966292043 ns/iter 1247549.3374998742 ns/iter 1.07
Pointer_Maybe_Tracked_Deeply_Nested/1 1602283.4988506339 ns/iter 1604177.9747705704 ns/iter 1.00
Pointer_Position_Tracker_Get_Deeply_Nested 683.3539321438848 ns/iter 685.4174106240721 ns/iter 1.00
URITemplateRouter_Create 31014.529446222175 ns/iter 34191.68991307193 ns/iter 0.91
URITemplateRouter_Match 188.6984724859833 ns/iter 186.31044121893783 ns/iter 1.01
URITemplateRouter_Match_BasePath 231.01726299798304 ns/iter 211.48599193217868 ns/iter 1.09
URITemplateRouterView_Restore 9903.392626791463 ns/iter 8477.630771257305 ns/iter 1.17
URITemplateRouterView_Match 145.01706949867958 ns/iter 146.23139397102122 ns/iter 0.99
URITemplateRouterView_Match_BasePath 169.4382432828959 ns/iter 162.27266147071654 ns/iter 1.04
URITemplateRouterView_Arguments 455.54416673817923 ns/iter 422.11048699418257 ns/iter 1.08
JSONL_Parse_Large 9172314.88311735 ns/iter 9654112.87500078 ns/iter 0.95
JSONL_Parse_Large_GZIP 10868762.312501445 ns/iter 11303464.290322961 ns/iter 0.96
HTML_Build_Table_100000 72093024.00000297 ns/iter 70960085.30000973 ns/iter 1.02
HTML_Render_Table_100000 5152907.7238802165 ns/iter 5106885.073528849 ns/iter 1.01
GZIP_Compress_ISO_Language_Set_3_Locations 35944629.79999662 ns/iter 32335123.13636311 ns/iter 1.11
GZIP_Decompress_ISO_Language_Set_3_Locations 4292406.398773217 ns/iter 4096645.0769230733 ns/iter 1.05
GZIP_Compress_ISO_Language_Set_3_Schema 2091109.7514970575 ns/iter 1857459.289124802 ns/iter 1.13
GZIP_Decompress_ISO_Language_Set_3_Schema 277022.13093356235 ns/iter 358085.5726714806 ns/iter 0.77
JOSE_VerifySignature_RS256 63735.5822080245 ns/iter 58233.01257075826 ns/iter 1.09
JOSE_VerifySignature_ES512 2697433.5968991756 ns/iter 2442595.9128920357 ns/iter 1.10

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 7d64593 Previous: 531d7ac Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 5.0772570000003725 ns/iter 5.025457054690371 ns/iter 1.01
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.1604883928584 ns/iter 5.071573999998691 ns/iter 1.02
Regex_Period_Asterisk 5.029925999999705 ns/iter 5.238328999998885 ns/iter 0.96
Regex_Group_Period_Asterisk_Group 5.097968000000037 ns/iter 5.1740000000027715 ns/iter 0.99
Regex_Period_Plus 4.834622300186296 ns/iter 5.011472456474445 ns/iter 0.96
Regex_Period 4.773944643923097 ns/iter 4.778966228745476 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 4.799753527857248 ns/iter 4.898475380559004 ns/iter 0.98
Regex_Caret_Group_Period_Plus_Group_Dollar 4.771659385650945 ns/iter 4.782215001069261 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 5.018345999999383 ns/iter 5.020406999997249 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.276404999999613 ns/iter 5.30768099999932 ns/iter 0.99
Regex_Caret_X_Hyphen 8.174905133928283 ns/iter 8.155630580358572 ns/iter 1.00
Regex_Period_Md_Dollar 44.05543125000122 ns/iter 43.96550625000373 ns/iter 1.00
Regex_Caret_Slash_Period_Asterisk 7.872369607711505 ns/iter 8.071543526781966 ns/iter 0.98
Regex_Caret_Period_Range_Dollar 5.750379999999495 ns/iter 5.643215178569758 ns/iter 1.02
Regex_Nested_Backtrack 56.02433928570706 ns/iter 55.50415178569372 ns/iter 1.01
JSON_Array_Of_Objects_Unique 551.6950999999608 ns/iter 527.0565178575127 ns/iter 1.05
JSON_Parse_1 10097.32813692638 ns/iter 8764.202391956742 ns/iter 1.15
JSON_Parse_Real 16800.756255061697 ns/iter 16224.174107141005 ns/iter 1.04
JSON_Parse_Decimal 12606.071428572412 ns/iter 12052.937499999774 ns/iter 1.05
JSON_Parse_Schema_ISO_Language 7585192.222222758 ns/iter 7853540.000002492 ns/iter 0.97
JSON_Parse_Integer 6381.102000000283 ns/iter 6123.693750002498 ns/iter 1.04
JSON_Parse_String_NonSSO_Plain 8244.623883926852 ns/iter 7880.233570390049 ns/iter 1.05
JSON_Parse_String_SSO_Plain 3780.2123567632993 ns/iter 3722.4453170610204 ns/iter 1.02
JSON_Parse_String_Escape_Heavy 23561.77812499993 ns/iter 21550.278125005207 ns/iter 1.09
JSON_Parse_Object_Short_Keys 14268.050142633521 ns/iter 13240.485756758513 ns/iter 1.08
JSON_Parse_Object_Scalar_Properties 7118.373578688588 ns/iter 6796.794642854463 ns/iter 1.05
JSON_Parse_Object_Array_Properties 12082.062499999323 ns/iter 11167.171875001713 ns/iter 1.08
JSON_Parse_Object_Object_Properties 11752.720312500742 ns/iter 11394.559374998891 ns/iter 1.03
JSON_Parse_Nested_Containers 81587.04241069918 ns/iter 79047.39955359373 ns/iter 1.03
JSON_From_String_Copy 63.78898437500169 ns/iter 63.7576874999825 ns/iter 1.00
JSON_From_String_Temporary 58.8265599999886 ns/iter 58.32088392858331 ns/iter 1.01
JSON_Number_To_Double 122.83028571431488 ns/iter 122.21321428577474 ns/iter 1.01
JSON_Object_At_Last_Key/8 7.260002232141817 ns/iter 7.231760714286597 ns/iter 1.00
JSON_Object_At_Last_Key/32 23.323097953978255 ns/iter 23.283746391928872 ns/iter 1.00
JSON_Object_At_Last_Key/128 89.82148259727846 ns/iter 89.70154956687855 ns/iter 1.00
JSON_Object_At_Last_Key/512 427.01218750011094 ns/iter 421.03276221509384 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 67.04707589284858 ns/iter 68.71018750002479 ns/iter 0.98
JSON_Equality_Helm_Chart_Lock 301.4345535713606 ns/iter 300.5706360969732 ns/iter 1.00
JSON_Divisible_By_Decimal 299.65261387799626 ns/iter 298.70952692975163 ns/iter 1.00
JSON_String_Equal/10 15.585196428570418 ns/iter 15.442430803572297 ns/iter 1.01
JSON_String_Equal/100 16.848397878247916 ns/iter 16.742179128964985 ns/iter 1.01
JSON_String_Equal_Small_By_Perfect_Hash/10 2.5242257142857785 ns/iter 2.5523774999994333 ns/iter 0.99
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 15.066598214283594 ns/iter 14.19167203486524 ns/iter 1.06
JSON_String_Fast_Hash/10 4.712965189091095 ns/iter 4.88349781359025 ns/iter 0.97
JSON_String_Fast_Hash/100 4.803581474286764 ns/iter 4.7464142857133345 ns/iter 1.01
JSON_String_Key_Hash/10 5.344542000000274 ns/iter 5.355871428573015 ns/iter 1.00
JSON_String_Key_Hash/100 11.902258928569966 ns/iter 11.867551562495748 ns/iter 1.00
JSON_Object_Defines_Miss_Same_Length 4.100038591918761 ns/iter 4.114862150204339 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 5.236320999999862 ns/iter 5.030422999998336 ns/iter 1.04
JSON_Object_Defines_Miss_Too_Large 4.448140625000008 ns/iter 4.400738124999748 ns/iter 1.01
Pointer_Object_Traverse 71.69464285713697 ns/iter 69.79264508929971 ns/iter 1.03
Pointer_Object_Try_Traverse 69.60458705356538 ns/iter 67.5324330357187 ns/iter 1.03
Pointer_Push_Back_Pointer_To_Weak_Pointer 164.00161366079797 ns/iter 184.41294984912554 ns/iter 0.89
Pointer_Walker_Schema_ISO_Language 7224541.111109929 ns/iter 8212094.666663082 ns/iter 0.88
Pointer_Maybe_Tracked_Deeply_Nested/0 2425483.534137177 ns/iter 2440317.424242094 ns/iter 0.99
Pointer_Maybe_Tracked_Deeply_Nested/1 3738341.7112301625 ns/iter 3719336.8983944943 ns/iter 1.01
Pointer_Position_Tracker_Get_Deeply_Nested 555.3227392318887 ns/iter 544.1932556676303 ns/iter 1.02
URITemplateRouter_Create 43356.879406978886 ns/iter 40619.06447681612 ns/iter 1.07
URITemplateRouter_Match 233.33803199345388 ns/iter 232.32877987405894 ns/iter 1.00
URITemplateRouter_Match_BasePath 269.3806459545364 ns/iter 264.0550357143314 ns/iter 1.02
URITemplateRouterView_Restore 32540.294379601302 ns/iter 32644.199128107528 ns/iter 1.00
URITemplateRouterView_Match 182.6170341622549 ns/iter 179.31815886761837 ns/iter 1.02
URITemplateRouterView_Match_BasePath 217.6108496602057 ns/iter 204.5537431003108 ns/iter 1.06
URITemplateRouterView_Arguments 533.644699999968 ns/iter 530.1538392858771 ns/iter 1.01
JSONL_Parse_Large 35872949.99999813 ns/iter 32558952.380960755 ns/iter 1.10
JSONL_Parse_Large_GZIP 39357676.190472074 ns/iter 33373252.380962577 ns/iter 1.18
HTML_Build_Table_100000 88243885.71429154 ns/iter 90632400.00003652 ns/iter 0.97
HTML_Render_Table_100000 7123871.428571452 ns/iter 8154862.222222114 ns/iter 0.87
GZIP_Compress_ISO_Language_Set_3_Locations 36249531.57894819 ns/iter 35954378.94735273 ns/iter 1.01
GZIP_Decompress_ISO_Language_Set_3_Locations 9693567.187500918 ns/iter 9865370.666666422 ns/iter 0.98
GZIP_Compress_ISO_Language_Set_3_Schema 2094935.6250000051 ns/iter 2095995.93749914 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Schema 590434.8214284839 ns/iter 610487.2321429866 ns/iter 0.97
JOSE_VerifySignature_RS256 21334.868749995905 ns/iter 21206.166212061442 ns/iter 1.01
JOSE_VerifySignature_ES512 1536230.8035713162 ns/iter 1548477.678571406 ns/iter 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 9c8fe48 into main Jul 3, 2026
12 checks passed
@jviotti jviotti deleted the clang-format-fix branch July 3, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant