Improve E2E test startup#465
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 81.88% 81.88%
=======================================
Files 5 5
Lines 414 414
=======================================
Hits 339 339
Misses 45 45
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E test S3 service startup to use floci’s /etc/floci/init/start.d initialization scripts plus a container healthcheck, so CI can reliably wait for fixture setup before running Go tests.
Changes:
- Added floci init scripts to create the S3 buckets/objects used by
s3sync_test.goand to signal completion via a sentinel file. - Introduced
docker-compose.e2e.ymlwith a healthcheck gating readiness on both floci health and fixture completion; updatedMakefiletargets to use Compose and updated CI to rely on the new wait behavior. - Removed the Renovate custom manager for
FLOCI_VERSIONafter removing that Makefile variable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/s3/start.d/00-s3-init.sh | Creates the S3 buckets and fixture objects inside the floci container during startup. |
| test/s3/start.d/99-done.sh | Writes a sentinel file used by the healthcheck to indicate init completion. |
| docker-compose.e2e.yml | Adds Compose-based floci service definition and readiness healthcheck. |
| Makefile | Switches E2E S3 service control to Docker Compose (s3, s3-bg, s3-down). |
| .github/workflows/ci.yml | Removes manual sleep/fixture setup; relies on make s3-bg waiting for readiness. |
| renovate.json | Removes now-unused custom manager for Makefile FLOCI_VERSION. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use start.d script and healthcheck to properly wait for setup