ci: modernize solaris config#5041
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5041 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 388 388
Lines 96467 96467
=======================================
Hits 77391 77391
Misses 19076 19076 🚀 New features to boost your workflow:
|
test/contrib/isotp.uts is dropped to prevent the tests from failing with ``` ━ UTScapy - Scapy 2.7.1rc1.post58 - 3.13.13 └ Loaded config file ./test/configs/solaris.utsc ERROR: Cannot remove test/contrib/isotp.uts from test files ``` It's a follow-up to 386d7fa where that file was removed. TLS-related tests are adjusted It's a follow-up to 219f2fe where the TLS tests were moved to test/scapy/layers/tls scapy-rpc tests are added AI-Assisted: no
evverx
force-pushed
the
solaris-test-config
branch
from
02d7338 to
793e0a7
Compare
evverx
changed the title
Contributor
|
Thanks for this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/contrib/isotp.uts is dropped to prevent the tests from failing with
It's a follow-up to 386d7fa where that
file was removed.
TLS-related tests are adjusted
It's a follow-up to 219f2fe where the
TLS tests were moved to test/scapy/layers/tls
scapy-rpc tests are added
AI-Assisted: no
It was tested in https://github.com/evverx/avahi/actions/runs/29078009229/job/86313970280?pr=3. A couple of tests failed there but those failures probably indicate bugs and need looking into. I went down a really deep rabbit hole there where MAC addresses aren't extracted correctly with use_pcap=True because the PF_LINK addresses aren't cast to sockaddr_dl (on *BSD as well) so those failures can be related to that (or not).