fix: warn about unknown toolchain file keys#4969
Open
ychampion wants to merge 1 commit into
Open
Conversation
Constraint: Preserve current behavior during the warning-first migration Rejected: Immediate rejection | Maintainer requested a compatibility warning before hard errors Confidence: high Scope-risk: narrow Directive: Keep warning paths stable until the hard-error follow-up lands Tested: targeted integration test, library tests, Clippy, rustfmt, mdBook, diff check Not-tested: full integration suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Unknown settings can be misspellings, but rejecting them immediately would break toolchain files that currently rely on ignored keys. This stages the stricter behavior requested in #4953 without changing current configuration semantics.
Closes #2876
Validation
cargo test --features=test --test test_bonanza rust_toolchain_toml_warns_on_unknown_keyscargo test --features=test --libcargo clippy --all-targets --features=test -- -D warningscargo fmt --all -- --checkmdbook buildgit diff --check