add i18n support#6796
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThis PR introduces a complete
Confidence Score: 5/5Safe to merge — no correctness bugs in the core translation or event-scope paths; all previous review concerns have been addressed in this revision. The event-scope cleanup, q=0 Accept-Language exclusion, conditional Secure cookie attribute, catalog load error handling, set_locale lazy-loader mapping, and CLI add_command guard are all correctly implemented. The remaining findings are a Decimal-to-float precision loss in the compact number format branch and the translation cache not being wired into hot reload — both are minor developer-experience limitations rather than correctness issues. runtime.py — compact format branch converts Decimal to float and the translation cache has no hot-reload integration. Important Files Changed
Reviews (9): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b9a5f5342
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "reflex-base >= 0.9.7.dev0", | ||
| "reflex >= 0.9.7.dev0", |
There was a problem hiding this comment.
Remove development pins before publishing reflex-i18n
With the new dispatch-release option, selecting reflex-i18n will create a release and trigger .github/workflows/publish.yml, whose publish job runs scripts/check_min_deps.py --check-dev-pins "$PACKAGE" and explicitly rejects published dependencies containing *.dev pins. Because these two requirements are part of reflex-i18n's published metadata, the publish workflow for any reflex-i18n release will fail at that gate until they are pinned to released versions.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I'll leave this open for the maintainers
closes #2339