Conversation
Contributor
Contributor
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
…nt vs. nice-to-have tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Documentation-only changes with no runtime or API behavior changes; incorrect guidance could mislead operators but does not alter product code.
Overview
Documents how Active-Active (CRDB) settings should be applied via
default_db_configversus per-instancedb_config, and wires that guidance through the REST API, CLI, and memory/OOM topics.The CRDB
database_configreference is restructured into four buckets: settings that must usedefault_db_config(replication-breaking if mismatched), should use it (operational consistency), recommended defaults (includingreplication_oom_threshold_percentwith a link to replication OOM protection), and fields that belong in per-instancedb_config(certs, port, mTLS flags, etc.). Related pages (crdb,instance_info, PATCH/POSTcrdbs, andcrdbs/updates) now point readers at that reference and clarify that updatingdefault_db_configapplies to existing and new instances while instancedb_configoverrides defaults.Replication OOM tuning in Active-Active planning and memory limits no longer documents single-BDB
PUT /v1/bdbs; it showsPATCH /v1/crdbs/{crdb_guid}withdefault_db_config.replication_oom_threshold_percentso the change applies across participating clusters.crdb-clicreate/update descriptions for--default-db-config/ file options now link to the same config reference.Reviewed by Cursor Bugbot for commit 2be5c19. Bugbot is set up for automated code reviews on this repo. Configure here.