Skip to content

Use Ubuntu 26.04 and Python 3.14#13027

Open
humitos wants to merge 5 commits into
update-dev-imagesfrom
humitos/lxml-python3.14
Open

Use Ubuntu 26.04 and Python 3.14#13027
humitos wants to merge 5 commits into
update-dev-imagesfrom
humitos/lxml-python3.14

Conversation

@humitos
Copy link
Copy Markdown
Member

@humitos humitos commented May 6, 2026

I had to upgrade xmlsec and lxml to versions compatible with Python 3.14. These versions have wheels available, so there are no need to compile them.

@humitos
Use Ubuntu 26.04 and Python 3.14
44a80cf 
I had to upgrade xmlsec and lxml to versions compatible with Python 3.14.
These versions have wheels available, so there are no need to compile them.
@humitos humitos requested a review from stsewd May 6, 2026 08:59
@humitos humitos requested a review from a team as a code owner May 6, 2026 08:59
@humitos humitos mentioned this pull request May 6, 2026
Open
@humitos humitos requested a review from a team as a code owner May 6, 2026 09:03
@humitos humitos requested a review from agjohnson May 6, 2026 09:03
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 6, 2026 •
edited
Loading

Documentation build overview

📚 dev | 🛠️ Build #32989331 | 📁 Comparing f6a0b2e against latest (221e32c)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 6, 2026 •
edited
Loading

Documentation build overview

📚 docs | 🛠️ Build #32989332 | 📁 Comparing f6a0b2e against latest (e08ef8f)

  🔍 Preview build  

7 files changed · ± 7 modified

± Modified

@humitos humitos mentioned this pull request Jun 2, 2026
Merged
ericholscher
ericholscher approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ericholscher ericholscher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- always love being on latest Python 😍 💯

I had AI review, and open another PR on top to add additional missing bits (like the RTD config :D)

#13097

@ericholscher ericholscher mentioned this pull request Jun 3, 2026
Merged
@stsewd
Copy link
Copy Markdown
Member

stsewd commented Jun 3, 2026

We should do the same on .com and rtd-ext

agjohnson
agjohnson approved these changes Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change tested against just community locally, or community and business?

The changes look good, but I know we just went through the xml lib upgrades with Ubuntu 26 as well. We need to ensure those work with allauth and especially SAML.

@humitos
Copy link
Copy Markdown
Member Author

humitos commented Jun 4, 2026

Was this change tested against just community locally, or community and business?

I only tested community so far. I can do business as well.

The changes look good, but I know we just went through the xml lib upgrades with Ubuntu 26 as well. We need to ensure those work with allauth and especially SAML.

I'm not sure how to test SAML locally --I will need help there or someone with the local setup configured can take on that test for me.

@ericholscher @claude
Builds: Update remaining Python 3.12 references to 3.14 (#13097)
f6a0b2e 
Follow-up to #13027 — updates the remaining Python 3.12 references that
were missed in the initial PR.

**Fixed:**
- `.github/workflows/pip-tools.yaml` — `python-version: "3.12"` →
`"3.14"`
- `.readthedocs.yml` — `python: "3.12"` → `"3.14"` and `os:
ubuntu-22.04` → `ubuntu-24.04`
- `AGENTS.md` / `.claude/CLAUDE.md` — `tox -e py312` → `tox -e py314`
- `requirements/pip.in` — grammar fix in comment

**Not changed (intentional):**
- `docs/user/` example configs — these show supported Python versions
for users, not the project's own version

---
*Generated by AI agent (Claude Code)*

---
_Generated by [Claude
Code](https://claude.ai/code/session_01PoSwN1ZgNm3mrboFs9kTDr)_

Co-authored-by: Claude <noreply@anthropic.com>
@agjohnson
Copy link
Copy Markdown
Contributor

agjohnson commented Jun 4, 2026

I'm not sure how to test SAML locally

We tested in staging last time, local testing of SAML is hard.

@stsewd
Copy link
Copy Markdown
Member

stsewd commented Jun 4, 2026

To test SAML locally, you can follow the same steps from https://docs.readthedocs.com/platform/stable/guides/set-up-single-sign-on-saml.html. There is an app for local testing in the Okta dev account. You all should have access to it now. I can also try to test it later.

@humitos
Copy link
Copy Markdown
Member Author

humitos commented Jun 4, 2026

By the way, don't we have tests for SAML? If we do, that should cover what we need here since the XML parsing would happen in our code.

@stsewd
Copy link
Copy Markdown
Member

stsewd commented Jun 4, 2026

By the way, don't we have tests for SAML? If we do, that should cover what we need here since the XML parsing would happen in our code.

We don't have end to end testing, in the past there have been errors when performing the actual flow, that's hard to test in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericholscher ericholscher ericholscher approved these changes

@agjohnson agjohnson agjohnson approved these changes

@stsewd stsewd Awaiting requested review from stsewd

Assignees

@humitos humitos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@humitos @stsewd @agjohnson @ericholscher