fix(make): propagate per-package failures in root Makefile loops#60
Merged
Conversation
A shell for loop exits with the status of its last iteration, so a failure in any package except the last one was swallowed and install/lint/format/test reported success. Track failures explicitly so every package still runs and the target exits non-zero if any package failed. Closes #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefiletargetsinstall,lint,format, andtestlooped over packages with a plain shellforloop, whose exit status is that of the last iteration only — a failure in any package exceptbenchmarkwas swallowed and the target reported success.fail=0; ... || fail=1; ...; exit $fail): every package still runs, all failures are reported, and the target exits non-zero if any package failed.Closes #55
Test Plan
$(MAKE)that fails forcoreonly: before the fix all four targets exited 0; after the fix all four exit non-zero while still iterating all 5 packages.make lintpasses end to end (all packages + docs scripts).make testpasses: 566 passed, 1 skipped across the five packages.