[snitch] NaN-box narrow FP loads (flw) in the LSU return path#109
Open
emiliengnr wants to merge 1 commit into
Open
[snitch] NaN-box narrow FP loads (flw) in the LSU return path#109emiliengnr wants to merge 1 commit into
emiliengnr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is a pull request for a bug I found.
flw does not NaN-box the loaded single-precision value. The FP LSU ties
fp_lsu_qsigned to 0, and the load return path gated NaN-boxing on
sign-extension (
(data[msb] | NaNBox) & sign_ext), so the boxing was droppedand flw zero-extended into the 64-bit FP register. When a later
double-precision instruction reads that register it sees an ordinary number
where the spec requires a NaN, and its result diverges from the reference.
The fix makes NaN-boxing unconditional in the load return path
(
(data[msb] & sign_ext) | NaNBox). It is bit-identical for the integer LSU(NaNBox=0) and forces the upper bits to all-ones for the FP LSU.