Skip to content

[snitch] NaN-box narrow FP loads (flw) in the LSU return path#109

Open
emiliengnr wants to merge 1 commit into
pulp-platform:mainfrom
emiliengnr:fix-flw-nanboxing
Open

[snitch] NaN-box narrow FP loads (flw) in the LSU return path#109
emiliengnr wants to merge 1 commit into
pulp-platform:mainfrom
emiliengnr:fix-flw-nanboxing

Conversation

@emiliengnr

Copy link
Copy Markdown

Hello, here is a pull request for a bug I found.

flw does not NaN-box the loaded single-precision value. The FP LSU ties
fp_lsu_qsigned to 0, and the load return path gated NaN-boxing on
sign-extension ((data[msb] | NaNBox) & sign_ext), so the boxing was dropped
and flw zero-extended into the 64-bit FP register. When a later
double-precision instruction reads that register it sees an ordinary number
where the spec requires a NaN, and its result diverges from the reference.

The fix makes NaN-boxing unconditional in the load return path
((data[msb] & sign_ext) | NaNBox). It is bit-identical for the integer LSU
(NaNBox=0) and forces the upper bits to all-ones for the FP LSU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant