[hardware] 🐛 Zero-extend the vslideup.vi/vslidedown.vi immediate#473
Open
emiliengnr wants to merge 1 commit into
Open
[hardware] 🐛 Zero-extend the vslideup.vi/vslidedown.vi immediate#473emiliengnr wants to merge 1 commit into
emiliengnr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, here is a pull request for a bug I found.
The Ara dispatcher sign-extends the 5-bit immediate of vslideup.vi and
vslidedown.vi (ara_req.stride = {{ELEN{rs1[19]}}, rs1}). The RISC-V vector spec
makes this immediate unsigned (16.3.1 and 16.3.2). For an immediate of 16 or
more the sign bit is set, so a small positive slide offset becomes a large
negative one, the slide moves the whole vector out of range and returns all
zeros, and the result diverges from Spike.
Changelog
Fixed
The fix zero-extends the immediate for the two slide cases (ara_req.stride =
{{ELEN{1'b0}}, rs1}). The signed scalar_op used by the other OPIVI instructions
is left unchanged, since their immediate is signed.
Checklist