Fix X11 support and add floating window hint for tiling WMs#164
Open
pepc84 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mewnala crashes on X11 systems with
GLFW Error: Wayland: Platform not initializedeven when building from source with--features x11.Root cause
The
x11feature inprocessing_pyo3/Cargo.tomlwas only passing it toprocessingbut not toprocessing_glfw, so GLFW never actually got built with X11 support.What I changed
processing_pyo3/Cargo.toml: addedprocessing_glfw/x11to the x11 featureprocessing_glfw/Cargo.toml: added thex11crate as an optional dependencyprocessing_glfw/src/lib.rs: set_NET_WM_WINDOW_TYPE_DIALOGon X11 so tiling WMs like i3 and sway automatically float the window instead of tiling itNote
X11 users still need to build with
--no-default-features --features x11,static-linkfor now. Wayland is still the default.Tested on
Arch Linux, i3/X11, AMD Radeon RX 6600 XT