Minor change to get proper output quoting in writeJannoFileWithoutEmptyCols#393
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
=======================================
Coverage 52.03% 52.03%
=======================================
Files 37 37
Lines 5994 5994
Branches 644 644
=======================================
Hits 3119 3119
Misses 2231 2231
Partials 644 644 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
OK, I think I understand the change, looks OK to me. I'm a bit surprised about the back and forth here... why do we first encode the Janno into byte string, then decode again, filter for non-empty columns using transpose and lists, and then encode back again. Isn't that one loop too many? Why can't we just do the filter immediately on the Janno Rows? Is that due to the columns perhaps not being aligned and uniform? Probably, right? |
|
In their normal state the janno rows have all sorts of types and it's complicated to determine if they are NA or not. After encoding every NA value is a string |
I noticed an issue in the output quoting of
writeJannoFileWithoutEmptyCols. It caused the output oftrident rectify --jannoRemoveEmptyto be unreadable to trident! The minimal change in this PR does seem to solve the problem.