Skip to content

Change logging from warning to debug to reduce logging#459

Open
dirixmjm wants to merge 1 commit into
mainfrom
ReduceLog
Open

Change logging from warning to debug to reduce logging#459
dirixmjm wants to merge 1 commit into
mainfrom
ReduceLog

Conversation

@dirixmjm

@dirixmjm dirixmjm commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Some of the battery nodes warning are really debug-related messages.

Summary by CodeRabbit

  • Chores
    • Reduced logging verbosity by adjusting log levels for various node operations to improve diagnostic output clarity.

@dirixmjm dirixmjm requested a review from a team as a code owner June 20, 2026 13:09
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 426c3962-a865-4f83-a030-ba07df573f5e

📥 Commits

Reviewing files that changed from the base of the PR and between 58de8c6 and 8408420.

📒 Files selected for processing (4)
  • plugwise_usb/nodes/node.py
  • plugwise_usb/nodes/scan.py
  • plugwise_usb/nodes/sed.py
  • plugwise_usb/nodes/sense.py

📝 Walkthrough

Walkthrough

Six _LOGGER.warning calls are downgraded to _LOGGER.debug across four node modules (node.py, scan.py, sed.py, sense.py). The affected messages cover caching-disabled early returns, switch-group responses, motion reset timer adjustments, maintenance interval detection, and awake-timer unavailability events. No control flow or logic is changed.

Changes

Log Verbosity Reduction

Layer / File(s) Summary
warning → debug log downgrades
plugwise_usb/nodes/node.py, plugwise_usb/nodes/scan.py, plugwise_usb/nodes/sed.py, plugwise_usb/nodes/sense.py
Six _LOGGER.warning(...) calls changed to _LOGGER.debug(...) for routine operational messages: caching-disabled path in node.py; switch-group response and motion reset timer in scan.py; maintenance interval detection and awake-timer unavailability in sed.py; switch-group response in sense.py.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • bouwew
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: converting warning-level logging to debug-level logging across multiple files to reduce logging verbosity.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ReduceLog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot requested a review from bouwew June 20, 2026 13:09
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.78%. Comparing base (58de8c6) to head (8408420).

Files with missing lines Patch % Lines
plugwise_usb/nodes/sed.py 0.00% 2 Missing ⚠️
plugwise_usb/nodes/sense.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          36       36           
  Lines        8192     8192           
=======================================
  Hits         6700     6700           
  Misses       1492     1492           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwew bouwew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants