Fix checkCaption#1092
Open
AntoineUsal wants to merge 10 commits into
Open
Conversation
Contributor
|
Can you add a test that shows the effect of the cjhanges. I was wondering if we need figure: because we have micElement: |
Contributor
|
Hi antoine did you check the configureFrom: and the explanationForConfiguration logic too? |
Contributor
|
Now the tests should all pass. |
Contributor
|
Nearly there
|
Contributor
|
@AntoineUsal Hi antoine did you check the configureFrom: and the explanationForConfiguration logic too? |
Collaborator
Author
|
I added testConfigureFrom and testExplanationForConfiguration in my latest commits |
Ducasse
reviewed
Jun 10, 2026
| ] | ||
|
|
||
| { #category : 'tests' } | ||
| MicFigureEmptyCaptionCheckerTest >> testExplanationForConfiguration [ |
Contributor
There was a problem hiding this comment.
This is not enough we should have a real check. else 'a' can be a valid explanation.
Check the other tests for the configuration in the system to see how this is usually done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1090