Rename popup to popover to be more consistent#984
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6cae4cca6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| min-width: min(180px, var(--popover-available-width)); | ||
| overflow-wrap: anywhere; | ||
| color: var(--diffs-marker-contrast, contrast-color(#fff, #000)); | ||
| color: var(--diffs-bg); |
There was a problem hiding this comment.
In light themes, and in any browser that does not apply the contrast-color(...) override, this now falls back to --diffs-bg, which is white for pierre-light; warning/info marker backgrounds such as --diffs-warning-light: #d5a910 then render white popover text at very low contrast (about 2.2:1), whereas the old per-severity warning contrast was black. The new contrast test only exercises the dark marker fixture, so light-themed marker popovers can become difficult to read unless the fallback remains severity/theme-aware.
Useful? React with 👍 / 👎.
| padding: 8px 12px; | ||
| min-width: min(180px, var(--popover-available-width)); | ||
| overflow-wrap: anywhere; | ||
| color: var(--diffs-marker-contrast, contrast-color(#fff, #000)); |
There was a problem hiding this comment.
did you mean for this change?
|
sorry for the bad name 😛 |
This comment has been minimized.
This comment has been minimized.
3 participants
Rename
data-marker-popuptodata-marker-popoverto match popover usage elsewhere. Popup screams ad to me, vs popover as accepted W3C term.