Fix TaCompositionElement>>selectors returning duplicated selectors#19764
Open
PrasannaBhavan2005 wants to merge 1 commit into
Open
Conversation
…ctors TaCompositionElement>>selectors was concatenating localSelectors with traitComposition selectors without deduplicating. When a method is defined both locally in the trait and in one of its used traits, the selector appeared multiple times in the returned collection. Fixed by converting to a Set before converting back to an Array, matching the approach already used in TaSequence>>selectors. Resolves pharo-project#19744
Member
|
For info I fixed this bug in this PR on top of speeding up the trait recompilation: |
Author
|
Hi @jecisc it was showing in the issues list, I didn't see that it was already resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ctors
TaCompositionElement>>selectors was concatenating localSelectors with traitComposition selectors without deduplicating. When a method is defined both locally in the trait and in one of its used traits, the selector appeared multiple times in the returned collection.
Fixed by converting to a Set before converting back to an Array, matching the approach already used in TaSequence>>selectors.
Resolves #19744