Skip to content

fix: make lint work#4886

Open
hannesa2 wants to merge 1 commit into
owncloud:masterfrom
hannesa2:FixLint
Open

fix: make lint work#4886
hannesa2 wants to merge 1 commit into
owncloud:masterfrom
hannesa2:FixLint

Conversation

@hannesa2

@hannesa2 hannesa2 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Fix one issue from #4686
But there are still more lint errors !

This one is gone:

Image

@hannesa2

hannesa2 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

As you can see, the action "Android Instrumented Data Tests" is still working properly

@hannesa2

hannesa2 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Btw, as you use several runner at the same time (here it waits > 24 minutes), I would merge "Validate Gradle Wrapper" into "Detekt" this would not extend the runtime of the job and you save at least one runner.

image

@jesmrec

jesmrec commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@hannesa2 thanks for the contribution, we'll take a look asap.

@jesmrec jesmrec assigned jesmrec and unassigned jesmrec Jun 10, 2026
@jesmrec jesmrec requested review from jesmrec and joragua June 10, 2026 15:54
@jesmrec jesmrec added this to the 4.9 - Next milestone Jun 10, 2026
@jesmrec

jesmrec commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

We'll merge this PR when we finish our work in the current release 4.8.1. Thanks again!!! also, i'd like @joragua to take a look as well.

About CI: gradle wrapper validation is a 10-secs-job, it should not abuse of the runner usage 😆 . You @hannesa2 unfortunately suffered the overload of some days ago, but that's not the rule.

About Lint: we are trusting Detekt as you noticed. I know that's not the same as Lint... the point is: to make Lint useful, we have either to fix all the reports beforehand, or set a baseline (that means, ignoring existing reports and only marking the new ones). At this point, i don't find any of those solutions are good at this point. If i'd have to go for one option, i'd take the baseline... all ideas and inputs are welcome.

Finally, for further PRs, it'd be cool that the name of the branch follow our convention. Some of the CI jobs depend on the branch prefix to execute: feature/, fix/, technical/, improvement/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants