daemon: extract gRPC server startup into start_grpc_server()#533
Merged
Conversation
Global::serve() has grown large and mixes the gRPC startup concern with the peer-accept loop. Extracting the spawn into a dedicated function separates the two responsibilities and makes each easier to follow. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
BGP was always bound to 0.0.0.0 and [::] regardless of any local_address_list in the config file or listen_addresses in the StartBgp gRPC request, making those settings ineffective. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
The gRPC API server address was hardcoded to 0.0.0.0:50051 with no way to change it, preventing deployments that need to bind to a specific interface or port. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
SessionAddrs and NegotiatedGr are only used within event/mod.rs and do not need to be visible to sibling submodules. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
accept_connection and start_grpc_server were sandwiched between two impl Global blocks, making the struct's methods harder to navigate. Moving the free functions after the impl block unifies it. Signed-off-by: FUJITA Tomonori <fujita.tomonori@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global::serve() has grown large and mixes the gRPC startup concern with the peer-accept loop. Extracting the spawn into a dedicated function separates the two responsibilities and makes each easier to follow.