Conversation
The hand-maintained async/sync client twins had silently diverged. Fix the
behavioral and annotation drift and lock the two behavioral fixes with tests:
- branch: sync merge now applies the 120s minimum timeout floor like async
- node: sync create(allow_upsert=True) excludes the hfid to avoid upsert overhead
- node: async artifact fetch uses the FETCH (not GENERATE) unsupported message
- node: fix sync resource-pool error text typo ("Allocate" -> "Allocated")
- client: fix async filters docstring return type (InfrahubNode, not the Sync)
- schema/node: converge private-helper annotations that drifted between twins
Add regression tests covering the upsert-hfid exclusion and the merge timeout
floor for both the async and sync clients.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Regenerated docs/docs/python-sdk/sdk_ref/infrahub_sdk/client.mdx to match the corrected InfrahubClient.filters docstring (list[InfrahubNode] instead of list[InfrahubNodeSync]) from the async/sync twin drift fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
fix: correct drifted async/sync twins and add parity regression tests
github-actions
Bot
added
the
type/documentation
Deploying infrahub-sdk-python with
|
| Latest commit: |
8c41010
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a25ec73.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## develop #1173 +/- ##
===========================================
+ Coverage 82.49% 82.88% +0.38%
===========================================
Files 139 139
Lines 12210 13074 +864
Branches 1823 2069 +246
===========================================
+ Hits 10073 10836 +763
- Misses 1576 1627 +51
- Partials 561 611 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
polmichel
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1169.
Summary by cubic
Aligns
InfrahubClientSyncwithInfrahubClientand fixes small SDK inconsistencies. Syncbranch.mergeenforces a 120s minimum timeout, and upsert creates now omithfidto avoid server overhead.branch.merge(sync): applies a 120s timeout floor viamax(120, default_timeout).create(allow_upsert=True)omitshfidin mutation payload (async and sync).client.filtersreturn type corrected tolist[InfrahubNode]and SDK reference updated.Written for commit 8c41010. Summary will update on new commits.