Set default in achievement evaluator editor save as form.#3018
Open
somiaj wants to merge 1 commit into
Open
Conversation
Set the first option to use the achievement evaluator in the current achievement as the default selected option in the save as form of the achievement evaluator editor if it was not already set from a previous post. This fixes openwebwork#2795.
drgrice1
reviewed
Jun 15, 2026
drgrice1
left a comment
drgrice1
left a comment
Member
There was a problem hiding this comment.
This looks fine.
I think that the "save as" tabs for this and for the PG problem editor need to be generally reworked. The behavior should be similar to the "save as" functionality for most file editors. That is if you choose a filename of an existing file, then you are asked if you want to replace that file or not.
drgrice1
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the first option to use the achievement evaluator in the current achievement as the default selected option in the save as form of the achievement evaluator editor if it was not already set from a previous post. This fixes #2795.
In testing this, this only fixes the issue I ran across where nothing was set as default. There are still some oddities and that could be improved. If you choose to
Save asa new achievement, the new file is created, but the editor reverts back to the evaluator of the current achievement. Overall this form needs improved and is not addressed here, as any issues are just current behavior.