Finalize the PG CodeMirror Editor for the 2.20 release.#2719
Conversation
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
2 times, most recently
from
49e41b0 to
4357265
Compare
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
from
4357265 to
21bb64a
Compare
|
This now also includes a change that fixes issue #2724. |
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
from
707b37f to
b2d19c7
Compare
|
In testing if the spell check selection is saved, I noticed that the checkbox state is saved between page loads, but when loading a new problem, the spell checker checkbox is checked, but the spell checker is not working. I have to click the spell checker twice to get it working (one to uncheck the second to check) again. |
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
from
b2d19c7 to
f1dbcd3
Compare
|
@somiaj: I made another change that fixes that. |
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Confirmed your change fixed the spell check issue.
|
@drgrice1 should we wait until you look into the PGML syntax highlighting issue I found before merging this? |
|
I think it would be good to go ahead and merge this. I am not sure when I will get to that issue. |
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
from
f1dbcd3 to
0cff147
Compare
|
Nevermind. The version this points to now also fixes issue the PGML syntax highlighting issue. |
|
Confirmed this fixed #2727 |
A non beta version 0.0.1 of the `@openwebwork/pg-codemirror-editor` has now been published. So make that the version for the 2.20 release. If there are any other changes the version can still be bumped if needed, but I doubt that there will be at this point. The `@openwebwork/codemirror-lang-pg` package that the `@openwebwork/pg-codemirror-editor` depends on has a non beta version published (version 0.0.1). The `codemirror-lang-perl` and `codemirror-lang-mt` packages are now also published in non beta status. Those are under my name still at this point since they are not specific to the openwebwork project.
drgrice1
force-pushed
the
freeze-pg-codemirror-editor-for-release
branch
from
0cff147 to
31188a0
Compare
3 participants
A non beta version 0.0.1 of the
@openwebwork/pg-codemirror-editorhas now been published. So make that the version for the 2.20 release. If there are any other changes the version can still be bumped if needed, but I doubt that there will be at this point.The
@openwebwork/codemirror-lang-pgpackage that the@openwebwork/pg-codemirror-editordepends on has a non beta version published (version 0.0.1).The
codemirror-lang-perlandcodemirror-lang-mtpackages are now also published in non beta status. Those are under my name still at this point since they are not specific to the openwebwork project.