Skip to content

fix(vector config): fix match_any crash on null (not exist) namespace_name when pod metadata annotation fails#3331

Open
vparfonov wants to merge 1 commit into
openshift:release-6.5from
vparfonov:log9584
Open

fix(vector config): fix match_any crash on null (not exist) namespace_name when pod metadata annotation fails#3331
vparfonov wants to merge 1 commit into
openshift:release-6.5from
vparfonov:log9584

Conversation

@vparfonov

Copy link
Copy Markdown
Contributor

Description

Use fallible string() with null coalescing instead of infallible string!() so events with missing kubernetes metadata default to log_type="application" instead of aborting the remap transform.

/cc @Clee2691
/assign @jcantrill

Links

…_name when pod metadata annotation fails

Use fallible string() with null coalescing instead of infallible string!()
so events with missing kubernetes metadata default to log_type "application"
instead of aborting the remap transform.

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b65c6a2e-17fd-4bc3-8759-2ea7d6fe80bd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from cahartma and jcantrill July 3, 2026 10:50
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vparfonov
Once this PR has been reviewed and has the lgtm label, please assign jcantrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest-required

3 similar comments
@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest-required

@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest-required

@vparfonov

Copy link
Copy Markdown
Contributor Author

/retest-required

@jcantrill

Copy link
Copy Markdown
Contributor

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2026
@openshift-ci

openshift-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Clee2691

Clee2691 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release/6.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants