fix(vector config): fix match_any crash on null (not exist) namespace_name when pod metadata annotation fails#3331
fix(vector config): fix match_any crash on null (not exist) namespace_name when pod metadata annotation fails#3331vparfonov wants to merge 1 commit into
Conversation
…_name when pod metadata annotation fails Use fallible string() with null coalescing instead of infallible string!() so events with missing kubernetes metadata default to log_type "application" instead of aborting the remap transform. Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/hold |
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Description
Use fallible
string()with null coalescing instead of infalliblestring!()so events with missing kubernetes metadata default tolog_type="application"instead of aborting the remap transform./cc @Clee2691
/assign @jcantrill
Links