feat: add BoundaryNudgingLayer for regional-global blending#223
Open
AswaniSahoo wants to merge 2 commits into
Open
feat: add BoundaryNudgingLayer for regional-global blending#223AswaniSahoo wants to merge 2 commits into
AswaniSahoo wants to merge 2 commits into
Conversation
Contributor
Author
|
@jacobbieker This implements the boundary nudging approach we discussed on Issue #3 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR adds
BoundaryNudgingLayer, which blends regional predictions with global context at domain boundaries using a relaxation zone.It builds on
RegionalForecasterfrom #221 to support boundary conditioning for issue #3. The layer is opt-in and does not change behavior when disabled.The layer includes:
RegionalForecaster.forward()after the residual connectionenable_nudging(default False),nudging_hidden_dimRelated to #3
How Has This Been Tested?
The following tests were added and run using
pytest:tests/test_regional_forecast.pyCommands run:
.\.venv\Scripts\python.exe -m pytest tests/test_regional_forecast.py -v.\.venv\Scripts\python.exe -m ruff check graph_weather/models/regional_forecast.py tests/test_regional_forecast.pyIf your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: