Fix LayerNorm crash when model.half() is used#2729
Open
OWU-4f5755 wants to merge 1 commit into
Open
Conversation
…as to fp32 in LayerNorm.forward(), matching the pattern already used in Linear and Conv1d. Thus, RuntimeError is prevented ('expected scalar type Float but found Half') when you call model.half() prior to transcription. Tested: model.half() + fp16=True transcription works. Standard path no.half() also works and isn't affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LayerNorm.forward()casts the input to fp32 but doesn't cast its ownweight/bias, so callingmodel.half()before transcription causes:LinearandConv1din the same file already guard against this by casting their weights to match the input dtype. This PR does the same forLayerNorm.Observed no overhead in the normal case (
.float()on an fp32 tensor is a no-op). Tested withmodel.half() + fp16=Trueand the standard path — both work.