feat: migrate Windows build scripts from nextcloud/client-building into admin/win/scripts#9873
Open
Copilot wants to merge 1 commit into
Open
feat: migrate Windows build scripts from nextcloud/client-building into admin/win/scripts#9873Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot created this pull request from a session on behalf of
mgallien
April 21, 2026 09:13
View session
Member
|
I would go ahead with this change. |
mgallien
force-pushed
the
copilot/move-batch-scripts-to-admin-win
branch
4 times, most recently
from
b63a63a to
846b940
Compare
…in/scripts Agent-Logs-Url: https://github.com/nextcloud/desktop/sessions/977d4996-08e2-4615-9395-f3f2de506a7a Co-authored-by: mgallien <168967+mgallien@users.noreply.github.com>
mgallien
force-pushed
the
copilot/move-batch-scripts-to-admin-win
branch
from
846b940 to
fbf932b
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-9873.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the non-obsolete, non-NSIS Windows batch scripts from the separate
nextcloud/client-building repository into this
repository under
admin/win/scripts/, so that all build tooling lives alongside the source itbuilds.
Traceability
build-qtkeychain.batbuild-zlib.batbuild-installer-exe.batmakensis.exe/nextcloud.nsi— NSIS EXE installer onlynextcloud.nsiNSIS.InstallOptions.iniinit.batzip.batChanges
New:
admin/win/scripts/(16 scripts +.gitignore+README.md)Core includes
defaults.inc.bat— all environment variable defaults; auto-derivesDESKTOP_REPO_PATHfrom the script's location (3 levels up = repository root);PROJECT_PATHdefault changed fromc:/Nextcloud/client-building→c:/Nextcloud;PULL_DESKTOP/CHECKOUT_DESKTOPdefault to0(scripts are already inside the repo)common.inc.bat— per-architecture Craft/Qt paths; addsCRAFT_PATHoverride guard and a default forEXTRA_DEPLOY_PATHdatetime.inc.bat/datetime.inc.callee.sh— locale-independent date helperTop-level entry points
build.bat— main orchestrator; NSIS step removedtask-build-log.bat— logging wrapper for Windows Task Schedulertask-build-job.sh— Git Bash entry point for Task SchedulerMulti-arch loop wrappers
build-desktop.bat,build-installer-collect.bat,build-installer-msi.batPer-architecture implementation scripts (key path change:
MY_REPOnow resolves toDESKTOP_REPO_PATHinstead of%PROJECT_PATH%/desktop)single-build-desktop.batsingle-build-installer-collect.batsingle-build-installer-msi.batUtilities
sign.bat— code signing viasigntool.exeupload.bat— SCP upload helperHousekeeping
.gitignore— negates the repo-levelbuild*rule forbuild*.batsource files in this directoryDocumentation
README.md— full contributor guide with prerequisites, quick-start, variable reference, script reference, artifact layout, and explicit note that NSIS creation is not includedBehaviour changes relative to client-building
DESKTOP_REPO_PATHPROJECT_PATH/desktopPROJECT_PATHdefaultc:/Nextcloud/client-buildingc:/NextcloudPULL_DESKTOP/CHECKOUT_DESKTOPdefaults1/1(always clone)0/0(use existing checkout)CRAFT_PATHEXTRA_DEPLOY_PATHcommon.inc.batbuild.batNo changes to
admin/win/msi/(WiX source files andmake-msi.bat.in)admin/win/tools/(NCMsiHelper, NCMigrationHelper, etc.)admin/win/CMakeLists.txtwindows-build-and-test.ymluses CraftMaster and is unaffected)src/gui/updater/NSIS runtime updater code (unrelated to installer creation)AI (if applicable)