Skip to content

Fix list item delete overrides#48

Merged
timkpaine merged 1 commit into
mainfrom
tkp/upd
Jun 7, 2026
Merged

Fix list item delete overrides#48
timkpaine merged 1 commit into
mainfrom
tkp/upd

Conversation

@timkpaine

@timkpaine timkpaine commented Jun 7, 2026

Copy link
Copy Markdown
Member

Port Hydra upstream change 6e489a92ce (facebookresearch/hydra#3146) for deleting ListConfig items by index via CLI override.

  • Cast nested delete keys to int when deleting from ListConfig parents.
  • Add regression coverage for ~x.0 and ~x.1 overrides.
  • Include staged notebook import formatting update.

Port Hydra upstream change 6e489a92ce (#3146) for deleting ListConfig items by index via CLI override.

- Cast nested delete keys to int when deleting from ListConfig parents.
- Add regression coverage for ~x.0 and ~x.1 overrides.
- Include staged notebook import formatting update.
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lerna/_internal/config_loader_impl.py 66.66% 2 Missing ⚠️
Files with missing lines Coverage Δ
lerna/tests/test_config_loader.py 100.00% <ø> (ø)
lerna/_internal/config_loader_impl.py 65.20% <66.66%> (+0.25%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

3 255 tests  +2   3 037 ✅ +2   6m 3s ⏱️ -49s
    2 suites ±0     218 💤 ±0 
    2 files   ±0       0 ❌ ±0 

Results for commit a8bcd5e. ± Comparison against base commit 4ab9037.

@timkpaine timkpaine merged commit a193def into main Jun 7, 2026
4 of 5 checks passed
@timkpaine timkpaine deleted the tkp/upd branch June 7, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant