[Fix] Protect TimescaleDB first boot with startupProbe#304
Merged
royischoss merged 3 commits intoJul 15, 2026
Merged
Conversation
This update introduces a startup probe for the TimescaleDB component, enhancing the readiness checks during deployment. The configuration includes parameters for period, timeout, and failure threshold, ensuring better management of the database's initialization process.
Co-authored-by: Cursor <cursoragent@cursor.com>
royischoss
reviewed
Jul 15, 2026
royischoss
left a comment
Collaborator
There was a problem hiding this comment.
Hey looks good to me small comment
Clarified the purpose of the failureThreshold parameter in the TimescaleDB startup probe configuration, indicating that it represents a 5-minute window for initdb on slow storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Stops TimescaleDB from being killed by the liveness probe during first-boot
initdbon slow storage.Without a
startupProbe, Kubernetes can interrupt initialization and leave a corruptPGDATA(missingglobal/pg_filenode.map), causing a permanent crash loop that breaks model-monitoring flows.This change adds a configurable TimescaleDB
startupProbeand forces probe checks over TCP (-h 127.0.0.1).🛠️ Changes Made
charts/mlrun-ce/templates/timescaledb/statefulset.yaml: addedstartupProbe; added-h 127.0.0.1to startup/liveness/readiness probes; removedinitialDelaySecondsfrom liveness/readiness (gated by startup probe)charts/mlrun-ce/values.yaml: addedtimescaledb.startupProbedefaults (periodSeconds: 10,timeoutSeconds: 5,failureThreshold: 30→ ~5 minute startup window)charts/mlrun-ce/Chart.yaml: bumped version0.12.0-rc.4→0.12.0-rc.5✅ Checklist
charts/mlrun-ce/Chart.yaml.🧪 Testing
helm lint charts/mlrun-ce— passed./tests/helm-template-test.sh— 82/82 passedmake tests/ Kind install — not runinitdbkill failure mode was documented on the Jira ticket🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes
Install-mode values files were not updated because
timescaledb.startupProbeis a default inherited fromvalues.yaml; admin install keepstimescaledb.enabled: false, and non-admin overlays do not need a probe override.Jenkins deploy health-gate for TimescaleDB (ticket item 3) still lives in
ce-deploymentand is out of scope for this PR.