Fix expm1 for complex inputs on the CPU backend#3760
Open
obchain wants to merge 1 commit into
Open
Conversation
The CPU expm1 used std::expm1, which has no complex overload, so for a complex input it operated on the real part and discarded the imaginary part (e.g. expm1(0.5 + 0.7j) returned expm1(0.5) + 0j). Add a complex branch that uses the defining identity exp(z) - 1, matching the complex handling already present for log1p and log2. Real and low-precision paths are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3759.
The CPU
expm1usedstd::expm1, which has no complex overload, so for a complex input it operated on the real part and discarded the imaginary part (e.g.expm1(0.5 + 0.7j)returnedexpm1(0.5) + 0j).Added a complex branch to
expm1inbase_simd.hthat uses the defining identityexp(z) - 1, matching the complex handling already present forlog1pandlog2. The real and low-precision (Accelerate / fp16) paths are unchanged.Before:
After it equals
exp(z) - 1.Verified the complex forward now matches
np.exp(z) - 1and that the (already correct)Expm1::jvpagrees with finite differences for complex inputs; real and fp16 results are unchanged. Added a complex case totest_expm1.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes