Skip to content

Add exist methods for button and select elements#630

Open
grom358 wants to merge 1 commit into
minkphp:masterfrom
grom358:webassert
Open

Add exist methods for button and select elements#630
grom358 wants to merge 1 commit into
minkphp:masterfrom
grom358:webassert

Conversation

@grom358

@grom358 grom358 commented Jan 8, 2015

Copy link
Copy Markdown
Contributor

Added exist methods for button and select elements

@aik099

aik099 commented Jan 8, 2015

Copy link
Copy Markdown
Member

And I guess the getComputedStyle methods got in this PR by accident again, like they did with your previous PR?

@grom358

grom358 commented Jan 9, 2015

Copy link
Copy Markdown
Contributor Author

@aik099 gah they did... mmmm.. I think I going to need to delete my Mink repo and refork. Will that cause any issues? will it break the other PR?

I think I must of pushed the getComputedStyle onto my fork's master.

@grom358

grom358 commented Jan 9, 2015

Copy link
Copy Markdown
Contributor Author

Okay I rebased onto upstream/master to solve for this PR

@aik099

aik099 commented Jan 9, 2015

Copy link
Copy Markdown
Member

I think I going to need to delete my Mink repo and refork.

I think instead you should be pulling upstream/master into your fork's grom358/origin and then rebasing PR on top of that.

I think I must of pushed the getComputedStyle onto my fork's master.

That's bad news.

Okay I rebased onto upstream/master to solve for this PR

Unfortunately GitHub says otherwise because it can't automatically merge this PR.

@stof

stof commented Jan 9, 2015

Copy link
Copy Markdown
Member

Okay I rebased onto upstream/master to solve for this PR

I guess you forgot to fetch upstream first, so using an outdated upstream/master

@grom358 grom358 closed this Jan 13, 2015
@grom358 grom358 deleted the webassert branch January 13, 2015 23:03
@grom358 grom358 restored the webassert branch January 13, 2015 23:03
@grom358 grom358 reopened this Jan 13, 2015
@grom358

grom358 commented Jan 13, 2015

Copy link
Copy Markdown
Contributor Author

My upstream was set to Behat/Mink ... problem solved.

@grom358

grom358 commented Jan 13, 2015

Copy link
Copy Markdown
Contributor Author

These duplicate scrutinizer errors are bogus.

@stof

stof commented Jan 14, 2015

Copy link
Copy Markdown
Member

@grom358 we don't consider duplications as failure conditions (because we know it's bogus in several places). the failure condition is for coding styles issues

@stof stof changed the title Webassert Add exist methods for button and select elements Jan 14, 2015
@grom358

grom358 commented Jan 22, 2015

Copy link
Copy Markdown
Contributor Author

@stof fixed the indenting issues... I had my editor on 2 space indents :S

@grom358

grom358 commented Feb 4, 2015

Copy link
Copy Markdown
Contributor Author

Was there anything else required for this PR?

@aik099

aik099 commented Feb 4, 2015

Copy link
Copy Markdown
Member

Maybe squash. @stof , do you see any other changes required before merging?

@stof stof modified the milestone: 1.7 Feb 4, 2015
@grom358

grom358 commented Mar 3, 2015

Copy link
Copy Markdown
Contributor Author

I have updated this PR for the 1.7 changes. Scrutinizer thinks code is duplicate but its not as far as I can tell. Just number of methods that look similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants