Add verified badge to PR timeline#8834
Open
alexr00 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a commit signature verification badge (with details popover) to the PR timeline in the editor webview, plumbing verification data from the GitHub GraphQL API through the extension’s timeline event model to the React UI.
Changes:
- Fetch commit
signaturedata via GraphQL and map it into a newCommitEvent.verificationfield. - Render a new
CommitVerificationBadgein the timeline commit row. - Add CSS for the verified/unverified pill and popover layout.
Show a summary per file
| File | Description |
|---|---|
| webviews/editorWebview/index.css | Styles for the verification pill and details popover. |
| webviews/components/timeline.tsx | Wires the new badge into commit timeline entries. |
| webviews/components/commitVerification.tsx | New UI component for verified/unverified pill + popover. |
| src/github/utils.ts | Maps GraphQL commit signature data into CommitEvent.verification. |
| src/github/queriesShared.gql | Extends commit fragment to request signature fields. |
| src/github/graphql.ts | Adds signature typing to the commit GraphQL model. |
| src/common/timelineEvent.ts | Adds CommitVerification and optional CommitEvent.verification. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Low
sandy081
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.