Remove chat.experimental.useSkillAdherencePrompt and make skill-adherence reminder unconditional

[Copilot]

This change starts implementation of removing chat.experimental.useSkillAdherencePrompt now that its gated behavior is the default. The skill-adherence reminder is no longer config-gated and is always considered during agent prompt construction (while still only rendering when indexed skills exist).

• Prompt behavior update

  • In AgentUserMessage, removed the config check around SkillAdherenceReminder and always include the component in reminderInstructions.
  • The existing SkillAdherenceReminder logic remains intact, so it still emits output only when the customizations index contains skills.

• Setting cleanup

  • Removed the obsolete USE_SKILL_ADHERENCE_PROMPT_SETTING constant from promptTypes.ts.
  • Removed now-unused import/injected configuration dependency tied to that setting in agentPrompt.tsx.

• Targeted coverage for new default

  • Added a focused unit test to assert the reminder text is present when vscode.customizations.index includes at least one skill entry.

// before
{this.configurationService.getNonExtensionConfig<boolean>(USE_SKILL_ADHERENCE_PROMPT_SETTING)
	&& <SkillAdherenceReminder chatVariables={this.props.chatVariables} />}

// after
<SkillAdherenceReminder chatVariables={this.props.chatVariables} />

Original prompt

Start implementation

The user has attached the following file paths as relevant context:

• .github/copilot-instructions.md
• .github/copilot-instructions.md
• AGENTS.md

[Chronological Review: The conversation began with the user requesting to plan a task by following the instructions in a specific prompt file. The user specified the need to remove the `chat.useSkillAdherencePrompt` setting and clean up, indicating that the behavior it controlled is now the new default. The user then initiated the implementation phase, signaling a transition from planning to action. The most recent state involved the user starting the implementation of the task.]

[Intent Mapping:

1. "Plan my task." - The user requested a structured plan for their task based on the provided prompt.
2. "Follow instructions in #prompt:plan.prompt.md with these arguments: remove chat.useSkillAdherencePrompt setting and clean up; the behavior it gates is now the new default." - The user specified the exact modifications needed for the task.
3. "Start implementation." - The user indicated readiness to begin executing the planned task.]

[Technical Inventory:

• Repository: vscode
• Current branch: main
• Default branch: main
• File in focus: /Users/digitarald/Developer/vscode/.github/copilot-instructions.md
• Key setting to modify: chat.useSkillAdherencePrompt]

[Code Archaeology:

• File: /Users/digitarald/Developer/vscode/.github/copilot-instructions.md
• Purpose: This file contains instructions related to GitHub Copilot's behavior.
• Recent changes discussed: Removal of the chat.useSkillAdherencePrompt setting and cleanup of the file.]

[Progress Assessment:

• Completed Tasks: The user has outlined the task and specified the changes needed.
• Partially Complete Work: The implementation phase has just started, with no specific changes made yet.]

[Context Validation: All necessary context for continuation is captured, including the specific file being worked on and the modifications required.]

[Recent Commands Analysis:

• Last Agent Commands: The user executed commands to plan the task and start implementation.
• Tool Results Summary: The user provided specific instructions for modifying the settings in the prompt file.
• Pre-Summary State: The agent was actively working on implementing the task as per the user's instructions when the token budget was exceeded.
• Operation Context: The commands executed were directly related to the user's goal of modifying the Copilot instructions to reflect new defaults.]

1. Conversation Overview: - Primary Objectives: - "Plan my task." - The user requested a structured plan. - "Follow instructions in #prompt:plan.prompt.md with these arguments: remove chat.useSkillAdherencePrompt setting and clean up; the behavior it gates is now the new default." - The user specified the modifications needed. - "Start implementation." - The user indicated readiness to begin executing the task. - Session Context: The conversation transitioned from planning to implementation, focusing on modifying settings in the Copilot instructions. - User Intent Evolution: The user moved from outlining a task to actively starting its implementation.

2. Technical Foundation:

• Repository: vscode
• Current branch: main
• Default branch: main
• File: /Users/digitarald/Developer/vscode/.github/copilot-instructions.md

3. Codebase Status:

• File Name: /Users/digitarald/Developer/vscode/.github/copilot-instructions.md
• Purpose: Contains instructions for GitHub Copilot's behavior.
• Current State: The user has specified changes to be made but has not yet implemented them.
• Key Code Segments: Removal of the chat.useSkillAdherencePrompt setting.
• Dependencies: This file's modifications are crucial for updating Copilot's behavior.

4. Problem Resolution:

• Issues Encountered: None reported yet; the user is in the initial stages of implementation.
• Solutions Implemented: The user has outlined the necessary changes to be made.
• Debugging Context: No ongoing troubleshooting efforts reported.
• Lessons Learned: The user has clarified the new default behavior for Copilot.

5. Progress Tracking:

• Completed Tasks: Task planning and specification of changes needed.
• Partially Complete Work: Implementation has just started.
• Validated Outcomes: No features confirmed working yet.

6. Active Work State:

• Current Focus: The user is focused on implementing the task as per the outlined plan.
• Recent Context: The user has just started the implementation phase after planning.
• Working Code: The specific changes to the Copilot instructions are being prepared for implementation.
• Immediate Context: The user was preparing to modify the settings in the Copilot instructions.

7. Recent Operations:

• Last Agent Commands: The user executed commands to plan and start implementation.
• Tool Results Summary: The user provided specific instructions for modifying the settings in the prompt file.
• Pre-Summ...

Created from VS Code.