Skip to content

feat/converter to v2#2924

Merged
baywet merged 2 commits into
support/v2from
feat/converter-to-v2
Jul 2, 2026
Merged

feat/converter to v2#2924
baywet merged 2 commits into
support/v2from
feat/converter-to-v2

Conversation

@baywet

@baywet baywet commented Jul 2, 2026

Copy link
Copy Markdown
Member

port of #2915 to v2

Mahdigln and others added 2 commits July 2, 2026 12:44
…ion (#2915)

* feat: add JsonConverter for OpenApiSchema System.Text.Json serialization

* fix: address review comments on OpenApiSchemaJsonConverter

* refactor: pass JsonNode directly to reader and improve reference tests

* fix: throw explicit JsonException on null node and add reference regression test

* chore: reverts noisy global.json change

* chore: reduce allocations during serialization

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

* chore: restores system import

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

* fix: do not serialize BOM

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

---------

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet requested a review from a team as a code owner July 2, 2026 16:47
@baywet baywet enabled auto-merge July 2, 2026 16:47
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in the branch is 41%. The coverage in the branch is 88%.

Show a code coverage summary of the most impacted files.
File 2f8b3d2 ebe93ff +/-
/home/runner/wo...MapParameter.cs 100% 0% -100%
/home/runner/wo...Deserializer.cs 81% 0% -81%
/home/runner/wo...pyReferences.cs 63% 31% -32%
/home/runner/wo...piJsonReader.cs 100% 72% -28%
/home/runner/wo...Deserializer.cs 90% 62% -28%
/home/runner/wo...s/OpenApiTag.cs 100% 76% -24%
/home/runner/wo...Deserializer.cs 100% 81% -19%
/home/runner/wo...Deserializer.cs 96% 81% -15%
/home/runner/wo...Deserializer.cs 97% 89% -8%
/home/runner/wo...piComponents.cs 94% 87% -7%

Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
77.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@baywet baywet merged commit 0259f44 into support/v2 Jul 2, 2026
16 of 17 checks passed
@baywet baywet deleted the feat/converter-to-v2 branch July 2, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants