Raise minimum Node version to 20 and install Node 24 in setup scripts#7957
Merged
Conversation
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
achamayou
June 19, 2026 11:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JavaScript test packages to require a newer Node.js baseline and makes the CI/dev setup scripts install a pinned Node.js release directly (rather than relying on the distro npm package), aligning the runtime used in CI/dev with the new minimum.
Changes:
- Raise
engines.nodeintests/npm-appandtests/js-interpreter-reusefrom>=14to>=20. - Add Node.js install logic to
scripts/setup-ci.shandscripts/setup-dev.shwhich downloads a pinned Node v24 tarball, verifies SHA256, installs to/opt/node, and symlinks into/usr/local/bin. - Remove
npmfrom the dependency install lists in both setup scripts.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/npm-app/package.json | Bumps Node engine requirement for the npm-app test bundle. |
| tests/js-interpreter-reuse/package.json | Bumps Node engine requirement for the interpreter reuse test package. |
| scripts/setup-dev.sh | Installs a pinned Node.js version (v24) from nodejs.org and removes reliance on distro npm. |
| scripts/setup-ci.sh | Installs a pinned Node.js version (v24) during CI dependency setup and removes distro npm. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: achamayou <4016369+achamayou@users.noreply.github.com>
achamayou
reviewed
Jun 22, 2026
achamayou
reviewed
Jun 22, 2026
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
maxtropets
approved these changes
Jun 22, 2026
maxtropets
reviewed
Jun 22, 2026
| tdnf -y install \ | ||
| clang-tools-extra \ | ||
| python-pip \ | ||
| curl \ |
Collaborator
There was a problem hiding this comment.
What is curl for? Don't see it used in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the declared minimum Node engine for the test packages and switches the dependency setup scripts to install Node.js 24 instead of relying on the distro
npmpackage (Node 20 on Azure Linux 3.0).Packages
tests/npm-appandtests/js-interpreter-reuse:engines.node>=14→>=20.Setup scripts
scripts/setup-ci.shandscripts/setup-dev.sh: newinstall_node()downloadsnode-v24.17.0-linux-x64.tar.gzfrom nodejs.org, verifies its SHA256, extracts to/opt/node, and symlinksnode/npm/npxinto/usr/local/bin.npmtdnf package from both scripts so the pinned Node 24 is the only one onPATH.Notes
js/ccf-apphas noenginesconstraint and is left unchanged; the published@microsoft/ccf-apppackage is unaffected.NODE_SHA256from the matchingSHASUMS256.txt.