Fix configuration values#4
Closed
pando85 wants to merge 2 commits into
Closed
Conversation
For version 1.1.0 environment vars were not working so we update to 2.0.0-beta3. Also boolean values were not working and we added them as args. Furthermore, auto relay rules were writed in YAML and only create configmap if needed.
Closed
Member
|
Thanks @pando85 — this was the original maildev 2.x fix, and it's now merged via #9 (which built on your work here and in #7, with credit in the commit). #9 keeps the auto-relay-rules-as-YAML + conditional ConfigMap approach you introduced, adds the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For version 1.1.0 environment vars were not working so we update to
2.0.0-beta3.
Also boolean values were not working and we added them as args.
Furthermore, auto relay rules were writed in YAML and only create
configmap if needed.