Use NightscoutUtils.constructURL for the Nightscout web viewer URL#712
Merged
Conversation
codebymini
approved these changes
Jul 19, 2026
marionbarker
approved these changes
Jul 19, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
approve from code review and test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nightscout web viewer built its URL by concatenating the token onto the base URL without any encoding, so a token containing characters like & or = would be silently mangled. It now goes through NightscoutUtils.constructURL, which percent-encodes the token. For a normal token the resulting URL is identical to before.
constructURL also skips assigning queryItems when there is nothing to add, so a setup without a token no longer gets a stray trailing question mark.