Remove pre-iOS 18 Live Activity code paths#711
Merged
Conversation
With the deployment target now at iOS 18, delete the legacy fallbacks and availability guards that only ran on older systems: - LiveActivityManager: remove startIfNeededLegacy and attemptLegacyRenewal (the Activity.request() start/renewal paths), unwrap the iOS 17.2 push-to-start guards, and drop the now-redundant @available attributes. - LoopFollowLiveActivity: collapse the dual ActivityConfiguration into the family-adaptive layout and inline contentMargins. - StorageCurrentGlucoseStateProvider: the renewal overlay is driven solely by laRenewalFailed. - EKEventStore: request full calendar access directly. - RestartLiveActivityIntent: drop the redundant iOS 16.4 availability attributes. Also delete the orphaned duplicate LoopFollow/LiveActivity/RestartLiveActivityIntent.swift, which was not referenced by any target and shadowed the maintained root copy.
marionbarker
approved these changes
Jul 19, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve from code review.
Test that it builds.
Test that LA works for iOS 18 and iOS 26 test phones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the deployment target is iOS 18, this removes the Live Activity code paths and availability guards that only ever ran on older systems.
Dead code removed
LiveActivityManager— deletedstartIfNeededLegacyandattemptLegacyRenewal(theActivity.request()-based start and renewal fallbacks), unwrapped the four#available(iOS 17.2, *)push-to-start guards, and dropped the three now-redundant@available(iOS 17.2, *)attributes. Push-to-start is the single creation path.LoopFollowLiveActivity— collapsed the dualActivityConfigurationinto the.small-family-adaptive layout, inlined.contentMargins(.all, 0)(removing theapplyActivityContentMarginsFixIfAvailableshim), and removed theiOSApplicationExtension 16.1/iOS 18.0attributes.StorageCurrentGlucoseStateProvider—showRenewalOverlaynow returnslaRenewalFaileddirectly.EKEventStore+Extensions— requests full calendar access directly instead of branching on iOS 17.RestartLiveActivityIntent— dropped the redundant@available(iOS 16.4, *)attributes (theiOS 26.0gate forcontinueInForeground()is kept).Also
LoopFollow/LiveActivity/RestartLiveActivityIntent.swift, which was not referenced by any target and shadowed the maintained root-level copy.