Migrate main LoopFollow target to a synchronized folder group#702
Merged
Conversation
Convert the main LoopFollow/ group from explicit file enumeration to a PBXFileSystemSynchronizedRootGroup so files are picked up from disk. This shrinks project.pbxproj from ~2900 to ~880 lines and removes it as a source of merge conflicts when files are added, moved, or deleted. Shared LiveActivity/GlucoseConversion sources that also build into the Live Activity extension are moved to a new Shared/ folder referenced by both targets. Info.plist is kept out of the copy phase via a membership exception. Also remove dead code that was on disk but never in the build: a stale duplicate RestartLiveActivityIntent, four unreferenced orphan files, and a leftover Core Data model unused since the initial commit.
…roups # Conflicts: # LoopFollow.xcodeproj/project.pbxproj
…roups # Conflicts: # LoopFollow.xcodeproj/project.pbxproj # LoopFollow/LiveActivity/RestartLiveActivityIntent.swift # RestartLiveActivityIntent.swift
…roups # Conflicts: # LoopFollow.xcodeproj/project.pbxproj
marionbarker
approved these changes
Jul 20, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Approve by test. Builds to iOS 18, iOS 26.
The Mac Catalyst build was fixed with PR #715. Apply that fix to this PR and builds to Mac Catalyst.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the main
LoopFollow/group to aPBXFileSystemSynchronizedRootGroup, so files are synced from disk instead of enumerated by hand.project.pbxprojdrops from ~2900 to ~880 lines and stops generating merge conflicts when files are added, moved, or removed.Shared/folder referenced by both targets.Info.plistis excluded from the copy phase via a membership exception.RestartLiveActivityIntent, four unreferenced orphan files, and a Core Data model unused since the initial commit.Builds clean via the workspace (app + embedded extension).