GEOMESA-3587 Kryo - Fix buffer overflow caused by setBuffer locking maxCapacity#3565
Merged
Merged
Conversation
Contributor
|
@EdgarLQS thank you for the fix! sorry to be a hassle, but before I can merge you'll have to sign the Eclipse contributor agreement here, using the same email as your git commits: https://www.eclipse.org/legal/eca/ |
When serializing large features (>65KB data), the buffer expansion path calls output.setBuffer(expanded) which locks maxCapacity to the new buffer's physical length. Since Output is a thread-local singleton, the residual maxCapacity prevents subsequent larger features from being serialized on the same thread, causing Buffer overflow. Fix by using the two-argument form setBuffer(expanded, -1) to preserve the unbounded maxCapacity semantics, consistent with existing usage in package.scala:100. Adds a regression test that verifies sequential serialization of increasingly large features does not fail.
EdgarLQS
force-pushed
the
fix-kryo-buffer-overflow
branch
from
3a3b294 to
8124be2
Compare
Contributor
Author
|
I have signed the ECA. Could you please re-trigger the validation check? |
elahrvivaz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing large features (>65KB data), the buffer expansion path calls output.setBuffer(expanded) which locks maxCapacity to the new buffer's physical length. Since Output is a thread-local singleton, the residual maxCapacity prevents subsequent larger features from being serialized on the same thread, causing Buffer overflow.
Fix by using the two-argument form setBuffer(expanded, -1) to preserve the unbounded maxCapacity semantics, consistent with existing usage in package.scala:100.
Adds a regression test that verifies sequential serialization of increasingly large features does not fail.