Fix PebbleDB v1.1.5 upgrade compatibility#400
Open
jeremyhahn wants to merge 1 commit into
Open
Conversation
Upgrades PebbleDB from v1.0.0 to v1.1.5 to fix critical crash bug in table cache cleanup that causes nil pointer dereference. Changes: - Update go.mod dependencies for PebbleDB v1.1.5 - Implement missing VFS methods required by new PebbleDB version: - Fd() returns invalid fd (-1) as lni/vfs doesn't expose descriptors - OpenReadWrite() for read/write file access - Preallocate() no-op (optimization hint not supported by lni/vfs) - Prefetch() no-op (optimization hint not supported by lni/vfs) - SyncData() delegates to Sync() - SyncTo() delegates to Sync() for full file sync - Add proper error handling and code formatting - All methods maintain compatibility with lni/vfs interface The upgrade resolves the production crash while maintaining full compatibility with dragonboat's existing VFS abstraction.
Author
|
What do we need to do to get this merged in? The pebble version used by dragonboat is extremely outdated and causing build problems for projects also using Pebble. |
|
|
it will be nice to have this officially merged into v4 branch along with #398 not sure what the hold up is, unless @lni or @kevburnsjr wants to make an official v4 release soon... i'm running my own set of local patches, not as clean as this one so prefer something right from the repo |
|
Can we merge this? |
Contributor
|
@biskit I can't make releases. I'm not a maintainer. Just a user. |
|
@lni it would be nice if you merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades PebbleDB from v1.0.0 to v1.1.5 to fix critical crash bug in table cache cleanup that causes nil pointer dereference.
Changes:
I believe this addresses the following related items:
#343
#337
#341