Drop unread CharCluster::form field#687
Merged
Merged
Conversation
This is vestigial: I believe it used to be passed to `swash`, but is no longer used since the switch to `harfrust`. `harfrust` does this check itself, and we only check for the font coverage calculation, so I think it's unlikely that with our current architecture this field would ever need to be exposed in the API.
taj-p
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is vestigial: I believe it used to be passed to
swash, but is no longer used since the switch toharfrust.harfrustalso does this check itself, and we only check for the font coverage calculation, so I think it's unlikely that with our current architecture this field would ever need to be exposed in the API.There's one more vestigial field (
Char::glyph_id), but that touches a bit more, so I'll open a separate PR for it.