DRAFT: Better white space collapse#680
Draft
nicoburns wants to merge 5 commits into
Draft
Conversation
…WhiteSpaceCollapse` modes
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
white-space-collapseportion of:white-spaceproperty #619Generated with Opus 4.8 High, with review/revisions from Fable. Some manual review has been done. More coming soon (before this is moved out of draft).
Changes made
PreserveBreaks,PreserveSpaces, andBreakSpacesvariants toWhiteSpaceCollapse.TreeBuilder(+ optimize the whitespace-collapsing in the
TreeBuilderto reuse a single buffer in-place rather than constructing a new string for every span (simple local refactor)).BreakSpaces, generate additional soft line-breaking opportunities. This is implemented within the line-breaking code rather than in the analysis.^ The last change is the cause of the snapshot changes, which look like an improvement to me: in the changed layouts, Parley's computed content width now tightly wrapping it's content rather than including trailing whitespace.
I also have some follow-ups (not included here) that:
WhiteSpaceCollapsea style rather than a weird out-of-band method on theTreeBuilderSee: https://github.com/nicoburns/parley/tree/with-whitespace-style for a branch that includes those changes