Configure clang-tidy static analysis in CMake#1190
Open
KvanTTT wants to merge 2 commits into
Open
Conversation
Enable already applied checks (from lightvector#1167)
- Install `clang-tidy` as a dependency across all platforms. - Enable `USE_CLANG_TIDY` option in CMake configurations.
KvanTTT
force-pushed
the
clang-tidy-analyser
branch
from
April 25, 2026 14:54
c09446b to
2bb87d0
Compare
KvanTTT
marked this pull request as ready for review
April 25, 2026 15:08
Contributor
Author
|
For some reason, the warnings are not being reported by MSVC compiler (but it works locally), but they are being reported on macOS and Linux: https://github.com/lightvector/KataGo/actions/runs/24933559965/job/73015201820?pr=1190 I recommend fixing/suppressing remaining and new warnings (for instance, introduced by ed71a1f) |
KvanTTT
commented
Apr 25, 2026
| endif() | ||
|
|
||
| set_target_properties(katago PROPERTIES | ||
| CXX_CLANG_TIDY "${CLANG_TIDY_EXE};-checks=-*,performance-inefficient-vector-operation,performance-unnecessary-copy-initialization,readability-non-const-parameter,readability-make-member-function-const;${CLANG_TIDY_EXTRA_ARGS}") |
Contributor
Author
There was a problem hiding this comment.
We probably could enable all performance-related lints:
performance-*
But it provokes too many warnings and most of them aren't valuable.
KvanTTT
force-pushed
the
clang-tidy-analyser
branch
from
July 26, 2026 12:19
2bb87d0 to
c09446b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable already applied checks (from #1167)