rebalance: handle channels without short_channel_id#888
Merged
daywalker90 merged 1 commit intoJun 29, 2026
Merged
Conversation
Collaborator
|
Good catch , thank you @bittylicious ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebalance plugin can crash in peer_from_scid when listpeerchannels returns entries without a short_channel_id, such as channels that are not yet announced/locked in.
This changes the lookup to use ch.get("short_channel_id") before comparing, matching the defensive pattern already used elsewhere in the plugin.
Observed against Core Lightning v26.06 while running an explicit rebalance; the RPC failed with KeyError: 'short_channel_id'.
Validation:\n- python3 -m py_compile rebalance/rebalance.py rebalance/test_rebalance.py