Skip to content

fix: add missing TROUBLESHOOTING_URL and COMPATIBILITY_URL constants#515

Open
lacymorrow wants to merge 1 commit into
mainfrom
fix/missing-menu-urls
Open

fix: add missing TROUBLESHOOTING_URL and COMPATIBILITY_URL constants#515
lacymorrow wants to merge 1 commit into
mainfrom
fix/missing-menu-urls

Conversation

@lacymorrow

Copy link
Copy Markdown
Owner

Summary

  • TROUBLESHOOTING_URL and COMPATIBILITY_URL were imported in menu.js but never defined in config.js, causing an uncaught Error: The url option is required exception on app start when openUrlMenuItem was called with undefined URLs.
  • Added both constants to config.js pointing to the GitHub readme game-compatibility section and the community compatibility issue (>>> List of Games (that work/don't work) #47).

Test plan

  • Run npm start — app should launch without the url option is required exception
  • Open Help menu → verify "Troubleshooting Guide" and "Game Compatibility List" links open correct URLs

These were imported in menu.js but never defined in config.js, causing
an uncaught exception on app start from openUrlMenuItem.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds and exports two new configuration constants, TROUBLESHOOTING_URL and COMPATIBILITY_URL, pointing to game compatibility resources on GitHub. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant